Merge pull request kubernetes#2125 from brendandburns/flake

Deflake the TestCreate test, by adding an explicit wait.
duda · Nov 3, 2014 · 6cc5b7d · 6cc5b7d
2 parents e99eac0 + f02fe2d
commit 6cc5b7d
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/pkg/apiserver/apiserver_test.go b/pkg/apiserver/apiserver_test.go
@@ -501,7 +501,14 @@ func TestUpdateMissing(t *testing.T) {
 }
 
 func TestCreate(t *testing.T) {
-	simpleStorage := &SimpleRESTStorage{}
+	wait := sync.WaitGroup{}
+	wait.Add(1)
+	simpleStorage := &SimpleRESTStorage{
+		injectedFunction: func(obj runtime.Object) (returnObj runtime.Object, err error) {
+			wait.Wait()
+			return &Simple{}, nil
+		},
+	}
 	handler := Handle(map[string]RESTStorage{
 		"foo": simpleStorage,
 	}, codec, "/prefix/version", selfLinker)
@@ -537,6 +544,7 @@ func TestCreate(t *testing.T) {
 	if itemOut.Status != api.StatusWorking || itemOut.Details == nil || itemOut.Details.ID == "" {
 		t.Errorf("Unexpected status: %#v (%s)", itemOut, string(body))
 	}
+	wait.Done()
 }
 
 func TestCreateNotFound(t *testing.T) {