Merge pull request kubernetes#2814 from satnam6502/list

Do not consider an empty string to be an error in list.go
duda · Dec 11, 2014 · 5523e03 · 5523e03
2 parents 5865ab7 + 7582884
commit 5523e03
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/pkg/util/list.go b/pkg/util/list.go
@@ -29,9 +29,6 @@ func (sl *StringList) String() string {
 
 func (sl *StringList) Set(value string) error {
 	for _, s := range strings.Split(value, ",") {
-		if len(s) == 0 {
-			return fmt.Errorf("value should not be an empty string")
-		}
 		*sl = append(*sl, s)
 	}
 	return nil

diff --git a/pkg/util/list_test.go b/pkg/util/list_test.go
@@ -30,13 +30,3 @@ func TestStringListSet(t *testing.T) {
 		t.Errorf("expected: %v, got: %v:", expected, sl)
 	}
 }
-
-func TestStringListSetErr(t *testing.T) {
-	var sl StringList
-	if err := sl.Set(""); err == nil {
-		t.Errorf("expected error for empty string")
-	}
-	if err := sl.Set(","); err == nil {
-		t.Errorf("expected error for list of empty strings")
-	}
-}