fix missing error type in watch decode

duda · Oct 13, 2014 · 38bf2f3 · 38bf2f3
1 parent d349145
commit 38bf2f3
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 47 deletions.
diff --git a/pkg/watch/json/decoder.go b/pkg/watch/json/decoder.go
@@ -51,7 +51,7 @@ func (d *Decoder) Decode() (watch.EventType, runtime.Object, error) {
 		return "", nil, err
 	}
 	switch got.Type {
-	case watch.Added, watch.Modified, watch.Deleted:
+	case watch.Added, watch.Modified, watch.Deleted, watch.Error:
 	default:
 		return "", nil, fmt.Errorf("got invalid watch event type: %v", got.Type)
 	}

diff --git a/pkg/watch/json/decoder_test.go b/pkg/watch/json/decoder_test.go
@@ -24,61 +24,65 @@ import (
 	"time"
 
 	"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
-	"github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1beta1"
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/api/testapi"
 	"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
 	"github.com/GoogleCloudPlatform/kubernetes/pkg/watch"
 )
 
 func TestDecoder(t *testing.T) {
-	out, in := io.Pipe()
-	decoder := NewDecoder(out, v1beta1.Codec)
-
-	expect := &api.Pod{TypeMeta: api.TypeMeta{ID: "foo"}}
-	encoder := json.NewEncoder(in)
-	go func() {
-		data, err := v1beta1.Codec.Encode(expect)
-		if err != nil {
-			t.Fatalf("Unexpected error %v", err)
-		}
-		if err := encoder.Encode(&watchEvent{watch.Added, runtime.RawExtension{json.RawMessage(data)}}); err != nil {
-			t.Errorf("Unexpected error %v", err)
-		}
-		in.Close()
-	}()
-
-	done := make(chan struct{})
-	go func() {
-		action, got, err := decoder.Decode()
-		if err != nil {
-			t.Fatalf("Unexpected error %v", err)
-		}
-		if e, a := watch.Added, action; e != a {
-			t.Errorf("Expected %v, got %v", e, a)
-		}
-		if e, a := expect, got; !reflect.DeepEqual(e, a) {
-			t.Errorf("Expected %v, got %v", e, a)
-		}
-		t.Logf("Exited read")
-		close(done)
-	}()
-	<-done
-
-	done = make(chan struct{})
-	go func() {
-		_, _, err := decoder.Decode()
-		if err == nil {
-			t.Errorf("Unexpected nil error")
-		}
-		close(done)
-	}()
-	<-done
-
-	decoder.Close()
+	table := []watch.EventType{watch.Added, watch.Deleted, watch.Modified, watch.Error}
+
+	for _, eventType := range table {
+		out, in := io.Pipe()
+		decoder := NewDecoder(out, testapi.Codec())
+
+		expect := &api.Pod{TypeMeta: api.TypeMeta{ID: "foo"}}
+		encoder := json.NewEncoder(in)
+		go func() {
+			data, err := testapi.Codec().Encode(expect)
+			if err != nil {
+				t.Fatalf("Unexpected error %v", err)
+			}
+			if err := encoder.Encode(&watchEvent{eventType, runtime.RawExtension{json.RawMessage(data)}}); err != nil {
+				t.Errorf("Unexpected error %v", err)
+			}
+			in.Close()
+		}()
+
+		done := make(chan struct{})
+		go func() {
+			action, got, err := decoder.Decode()
+			if err != nil {
+				t.Fatalf("Unexpected error %v", err)
+			}
+			if e, a := eventType, action; e != a {
+				t.Errorf("Expected %v, got %v", e, a)
+			}
+			if e, a := expect, got; !reflect.DeepEqual(e, a) {
+				t.Errorf("Expected %v, got %v", e, a)
+			}
+			t.Logf("Exited read")
+			close(done)
+		}()
+		<-done
+
+		done = make(chan struct{})
+		go func() {
+			_, _, err := decoder.Decode()
+			if err == nil {
+				t.Errorf("Unexpected nil error")
+			}
+			close(done)
+		}()
+		<-done
+
+		decoder.Close()
+	}
 }
 
 func TestDecoder_SourceClose(t *testing.T) {
 	out, in := io.Pipe()
-	decoder := NewDecoder(out, v1beta1.Codec)
+	decoder := NewDecoder(out, testapi.Codec())
 
 	done := make(chan struct{})