Merge pull request kubernetes#5316 from lavalamp/fix6

fix goroutine leak
duda · Mar 11, 2015 · 0aee25e · 0aee25e
2 parents 18d1a1e + cc3a433
commit 0aee25e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/apiserver/resthandler.go b/pkg/apiserver/resthandler.go
@@ -392,8 +392,10 @@ type resultFunc func() (runtime.Object, error)
 // finishRequest makes a given resultFunc asynchronous and handles errors returned by the response.
 // Any api.Status object returned is considered an "error", which interrupts the normal response flow.
 func finishRequest(timeout time.Duration, fn resultFunc) (result runtime.Object, err error) {
-	ch := make(chan runtime.Object)
-	errCh := make(chan error)
+	// these channels need to be buffered to prevent the goroutine below from hanging indefinitely
+	// when the select statement reads something other than the one the goroutine sends on.
+	ch := make(chan runtime.Object, 1)
+	errCh := make(chan error, 1)
 	go func() {
 		if result, err := fn(); err != nil {
 			errCh <- err