Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable System credential extension on release + translations #3706

Merged
merged 10 commits into from
Dec 10, 2024
Merged

Enable System credential extension on release + translations #3706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d2f899c
New details screen + associated helper classes moved to Core where po…
amddg44 Dec 10, 2024
4f340e6
iOS 18 support for Autofill > Passwords tooltip + ability to access d…
amddg44 Dec 10, 2024
302f9a7
Copy update from ship review
amddg44 Dec 10, 2024
25b54fc
Ship review feedback changes - speeding up auth on iOS 18 + adding pr…
amddg44 Dec 10, 2024
846ae7d
Pixels implemented
amddg44 Dec 10, 2024
35aacad
Enabling extension on release builds
amddg44 Dec 10, 2024
f35fa09
Updates due to moving to Core
amddg44 Dec 10, 2024
fa90188
Translations
amddg44 Dec 10, 2024
e22b811
Fix linter warnings
amddg44 Dec 10, 2024
55f78d2
Update unit test
amddg44 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updates due to moving to Core
  • Loading branch information
@amddg44
amddg44 committed Dec 10, 2024
commit f35fa0999f8aecc7655797971fc9e773b35fb80f
4 changes: 2 additions & 2 deletions Core/AutofillInterfaceEmailTruncator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

import Foundation

struct AutofillInterfaceEmailTruncator {
static func truncateEmail(_ email: String, maxLength: Int) -> String {
public struct AutofillInterfaceEmailTruncator {
public static func truncateEmail(_ email: String, maxLength: Int) -> String {
let emailComponents = email.components(separatedBy: "@")
if emailComponents.count > 1 && email.count > maxLength {
let ellipsis = "..."
Expand Down
10 changes: 7 additions & 3 deletions Core/PasswordHider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,15 @@

import Foundation

struct PasswordHider {
let password: String
var hiddenPassword: String {
public struct PasswordHider {
public let password: String
public var hiddenPassword: String {
let maximumPasswordDisplayCount = 22
let passwordCount = password.count > maximumPasswordDisplayCount ? maximumPasswordDisplayCount : password.count
return String(repeating: "•", count: passwordCount)
}

public init(password: String) {
self.password = password
}
}
Loading