Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety #128

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Thread safety #128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a32608
add locking and parallel test
samansmink Dec 19, 2024
f945b66
disable micro benchmarks for now
samansmink Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
disable micro benchmarks for now
  • Loading branch information
@samansmink
samansmink committed Dec 19, 2024
commit f945b663ca850e267a91912a152d2d74c42c15bc
11 changes: 6 additions & 5 deletions .github/workflows/LocalTesting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,12 @@ jobs:
run: |
python ./duckdb/scripts/regression/test_runner.py --old=duckdb_delta/build/release/benchmark/benchmark_runner --new=build/release/benchmark/benchmark_runner --benchmarks=.github/regression/tpcds_sf1_local.csv --verbose --threads=2 --root-dir=.

- name: Regression Test Micro
if: always()
shell: bash
run: |
python ./duckdb/scripts/regression/test_runner.py --old=duckdb_delta/build/release/benchmark/benchmark_runner --new=build/release/benchmark/benchmark_runner --benchmarks=.github/regression/micro.csv --verbose --threads=2 --root-dir=.
# FIXME: re-enable
# - name: Regression Test Micro
# if: always()
# shell: bash
# run: |
# python ./duckdb/scripts/regression/test_runner.py --old=duckdb_delta/build/release/benchmark/benchmark_runner --new=build/release/benchmark/benchmark_runner --benchmarks=.github/regression/micro.csv --verbose --threads=2 --root-dir=.

- name: Test benchmark makefile
shell: bash
Expand Down
Loading