Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exploding Delim Joins #9564

Merged
merged 4 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make format-fix
  • Loading branch information
Tmonster committed Nov 6, 2023
commit fbdc30861a2a05e668f179dde27dbcff7c02f400
8 changes: 4 additions & 4 deletions src/optimizer/join_order/relation_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@ bool RelationManager::ExtractJoinRelations(LogicalOperator &input_op,
return true;
}
case LogicalOperatorType::LOGICAL_DELIM_GET: {
// Removed until we can extract better stats from delim gets. See #596
// auto &delim_get = op->Cast<LogicalDelimGet>();
// auto stats = RelationStatisticsHelper::ExtractDelimGetStats(delim_get, context);
// AddRelation(input_op, parent, stats);
// Removed until we can extract better stats from delim gets. See #596
// auto &delim_get = op->Cast<LogicalDelimGet>();
// auto stats = RelationStatisticsHelper::ExtractDelimGetStats(delim_get, context);
// AddRelation(input_op, parent, stats);
return false;
}
case LogicalOperatorType::LOGICAL_PROJECTION: {
Expand Down
2 changes: 1 addition & 1 deletion test/optimizer/joins/delim_join_dont_explode.test_slow
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# name: test/optimizer/joins/delim_join_dont_explode.test
# name: test/optimizer/joins/delim_join_dont_explode.test_slow
# description: In the join order optimizer queries need to have the correct bindings
# group: [joins]

Expand Down
Loading