Fix #15659: VARCHAR parameters now count as STRING_LITERAL again #15724
+33
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15659
This partially reverts #12759 for
VARCHAR
columns.Previously parameters would always count as literals - i.e. passing in a parameter
1
would bind as anINTEGER_LITERAL
, and a parameter'str'
would bind as a string literal. This matters because literals have special binding rules where they adopt surrounding types, so string literals can be used as dates, butVARCHAR
columns cannot (see literal typing here)For integer literals this fixes issues where types were ignored causing overflow errors when used in conjunction with smaller integer types. For string literals, however, this can cause previously working code to now throw binder errors. This PR reverts the behavior so that the code in the linked issue works again.