Fix RevertAppendInternal #11177
Merged
Fix RevertAppendInternal #11177
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just checked and with these changes, both |
taniabogatsch
approved these changes
Mar 15, 2024
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 17, 2024
Merge pull request duckdb/duckdb#11177 from Mytherin/fixrevertappendinternal Merge pull request duckdb/duckdb#11187 from carlopi/centralized_twine_upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #11173
Changes made in #11011 resulted in
total_rowsonly being updated and version info only being appended inFinalizeAppend. When reverting,FinalizeAppendis never called. This lead to not all rows being correctly reverted which lead to rows remaining in the table in case of constraint failures.This PR alters
RevertAppendInternalto no longer look attotal_rows, and instead directly look into the segments to clean up the appends.