test that explicitly set values are not overridden when we create the…

… temp_directory
duckdb · Mytherin · Apr 17, 2024 · Mar 1, 2024 · Mar 1, 2024 · Mar 1, 2024
commit 8c8ffe6ef20c7983f336c3e9d001a447b848367c
diff --git a/test/sql/storage/max_swap_space.test → ...torage/temp_directory/max_swap_space.test b/test/sql/storage/max_swap_space.test → ...torage/temp_directory/max_swap_space.test
@@ -1,5 +1,5 @@
-# name: test/sql/storage/max_swap_space.test
-# group: [storage]
+# name: test/sql/storage/temp_directory/max_swap_space.test
+# group: [temp_directory]
 
 require skip_reload
 
@@ -106,6 +106,3 @@ CREATE TABLE t2 AS SELECT * FROM range(1000000);
 query I
 select current_setting('max_temp_directory_size') a where a == '0 bytes'
 ----
-
-## TODO: test that the explicitly set value by the user does not get overridden when 'temp_directory' is set to a directory that doesn't exist yet
-# when the 'temp_directory' is created by us - the explicitly set value should not be overridden
diff --git a/test/sql/storage/temp_directory/max_swap_space_explicit.test b/test/sql/storage/temp_directory/max_swap_space_explicit.test
@@ -0,0 +1,29 @@
+# name: test/sql/storage/temp_directory/max_swap_space_explicit.test
+# group: [temp_directory]
+
+require skip_reload
+
+statement ok
+PRAGMA memory_limit='2MB'
+
+# --- Not changed when set explicitly by the user
+
+# If we set 'max_temp_directory_size' explicitly, it will not be overridden
+statement ok
+set max_temp_directory_size='15gb'
+
+# When we change the temp_directory to something that doesnt exist
+statement ok
+set temp_directory = '__TEST_DIR__/this_directory_should_not_exist__swap_space'
+
+query I nosort explicitly_set
+select current_setting('max_temp_directory_size')
+----
+
+statement ok
+CREATE TABLE t2 AS SELECT * FROM range(1000000);
+
+# The 'temp_directory' was created, but the value of 'max_temp_directory_size' was set explicitly, so it was unaltered
+query I nosort explicitly_set
+select current_setting('max_temp_directory_size')
+----