Merge branch 'main' into bp-bug

duckdb · Mytherin · Jan 23, 2024 · Jan 9, 2024 · Jan 16, 2024 · Jan 17, 2024
commit d86a6445514b68cff8cd2b5787c3653c5ee8bbeb
diff --git a/scripts/run_tests_one_by_one.py b/scripts/run_tests_one_by_one.py
@@ -4,41 +4,19 @@
 import os
 import time
 
-no_exit = False
-profile = False
-assertions = True
-force_storage_flag = ''
-
-for i in range(len(sys.argv)):
-    if sys.argv[i] == '--no-exit':
-        no_exit = True
-        del sys.argv[i]
-        i -= 1
-    elif sys.argv[i] == '--profile':
-        profile = True
-        del sys.argv[i]
-        i -= 1
-    elif sys.argv[i] == '--no-assertions':
-        assertions = False
-        del sys.argv[i]
-        i -= 1
-    elif sys.argv[i] == '--force-storage':
-        force_storage_flag = '--force-storage'
-        del sys.argv[i]
-        i -= 1
-
-if len(sys.argv) < 2:
-    print(
-        "Expected usage: python3 scripts/run_tests_one_by_one.py build/debug/test/unittest [--no-exit] [--profile] [--no-assertions] [--force-storage]"
-    )
-    exit(1)
-unittest_program = sys.argv[1]
-extra_args = []
-if len(sys.argv) > 2:
-    extra_args = [sys.argv[2]]
+import argparse
+
+parser = argparse.ArgumentParser(description='Run tests one by one with optional flags.')
+parser.add_argument('unittest_program', help='Path to the unittest program')
+parser.add_argument('--no-exit', action='store_true', help='Do not exit after running tests')
+parser.add_argument('--profile', action='store_true', help='Enable profiling')
+parser.add_argument('--no-assertions', action='store_false', help='Disable assertions')
+parser.add_argument('--time_execution', action='store_true', help='Measure and print the execution time of each test')
+
+args, extra_args = parser.parse_known_args()
 
-if force_storage_flag != '':
-    extra_args.append(force_storage_flag)
+if not args.unittest_program:
+    parser.error('Path to unittest program is required')
 
 # Access the arguments
 unittest_program = args.unittest_program

diff --git a/src/storage/compression/bitpacking.cpp b/src/storage/compression/bitpacking.cpp
@@ -768,7 +768,8 @@ unique_ptr<SegmentScanState> BitpackingInitScan(ColumnSegment &segment) {
 template <class T, class T_S = typename MakeSigned<T>::type>
 void BitpackingScanPartial(ColumnSegment &segment, ColumnScanState &state, idx_t scan_count, Vector &result,
                            idx_t result_offset) {
-	auto &scan_state = static_cast<BitpackingScanState<T> &>(*state.scan_state);
+	auto &scan_state = state.scan_state->Cast<BitpackingScanState<T>>();
+
 	T *result_data = FlatVector::GetData<T>(result);
 	result.SetVectorType(VectorType::FLAT_VECTOR);