Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bitpacking skip performance + better testing of FetchRow #10295

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Improve bitpacking skip performance + better testing of FetchRow #10295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b3d7193
improve bp skip and fix bp bug
samansmink Jan 9, 2024
5403a3b
verification of force fetch row
samansmink Jan 16, 2024
602e642
fix non deterministic test
samansmink Jan 17, 2024
718255f
fix non deterministic test
samansmink Jan 17, 2024
581194e
more fine-grained fetch-row-verification
samansmink Jan 17, 2024
032cfef
more fine-grained fetch-row-verification
samansmink Jan 17, 2024
52cc2c2
Merge branch 'main' into bp-bug
samansmink Jan 17, 2024
6a43cf3
small fix after merge
samansmink Jan 17, 2024
a2f1ea9
generate enums
samansmink Jan 17, 2024
d86a644
Merge branch 'main' into bp-bug
samansmink Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into bp-bug
  • Loading branch information
@samansmink
samansmink committed Jan 17, 2024
commit 52cc2c29a21a6450d6b9dd57faca8669b37823c8
4 changes: 2 additions & 2 deletions src/function/table/table_scan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
#include "duckdb/planner/operator/logical_get.hpp"
#include "duckdb/storage/data_table.hpp"
#include "duckdb/storage/table/scan_state.hpp"
#include "duckdb/common/serializer/serializer.hpp"
#include "duckdb/common/serializer/deserializer.hpp"
#include "duckdb/transaction/duck_transaction.hpp"
#include "duckdb/transaction/local_storage.hpp"
#include "duckdb/main/client_data.hpp"

namespace duckdb {
Expand Down
7 changes: 4 additions & 3 deletions test/sql/aggregate/aggregates/test_sem.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ select sem(v),sem(v2) from aggr
3.577709 5.663398

# Window Function
query I rowsort
select sem(v) over (partition by k)
from aggr ORDER BY ALL;
query II
select k, sem(v) over (partition by k)
from aggr
order by all
----
1 0.0
2 3.6975498644372604
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.