Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dbt-common + dbt-adapters #342

Merged
merged 20 commits into from
May 8, 2024
Merged

Migrate to dbt-common + dbt-adapters #342

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1e25859
Migrate to dbt-common + dbt-adapters
jtcohen6 Feb 19, 2024
86eface
Try different install reqs
jtcohen6 Feb 19, 2024
2d36968
Fix unit tests
jtcohen6 Feb 19, 2024
3ad787e
Bonus: functional tests for dbt unit testing
jtcohen6 Feb 19, 2024
d4d5939
bump dbt-common and dbt-adapters to 1.0.0b1
MichelleArk Feb 29, 2024
10034b3
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
MichelleArk Feb 29, 2024
5712711
implement DuckDbRelation.create_from, fix TestExternalSources::test_e…
MichelleArk Feb 29, 2024
af5f989
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
MichelleArk Mar 15, 2024
9c8113a
use RelationConfig attributes in create_from_source
MichelleArk Mar 15, 2024
80b709d
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
MichelleArk Mar 19, 2024
b8fdca0
formatting + initial mypy fixes
MichelleArk Mar 19, 2024
6527752
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
jtcohen6 Apr 9, 2024
9a0ba02
Revert dev-requirements
jtcohen6 Apr 10, 2024
6dcc39c
Readd dbt-tests-adapter
jtcohen6 Apr 10, 2024
5f594c4
Readd dbt-core to setup.py for install back-compat
jtcohen6 Apr 16, 2024
8511b94
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
jtcohen6 Apr 16, 2024
0750e0c
Merge remote-tracking branch 'origin/master' into jerco/migrate-dbt-c…
jtcohen6 Apr 16, 2024
a85cef9
Skip BV for TestUnitTestingTypesDuckDB
jtcohen6 Apr 19, 2024
298f27c
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
jwills May 3, 2024
08d5530
Merge branch 'master' into jerco/migrate-dbt-common-adapters-interfaces
jwills May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Readd dbt-core to setup.py for install back-compat
  • Loading branch information
@jtcohen6
jtcohen6 committed Apr 16, 2024
commit 5f594c40292c3dd7a7266b9931e8a5cad9a5b736
6 changes: 4 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ def _dbt_duckdb_version():
packages=find_namespace_packages(include=["dbt", "dbt.*"]),
include_package_data=True,
install_requires=[
"dbt-common>=1.0.0b1,<2.0",
"dbt-adapters>=1.0.0b1,<2.0",
"dbt-common>=1,<2",
"dbt-adapters>=1,<2",
"duckdb>=0.7.0",
# add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency
"dbt-core>=1.8.0b1",
Comment on lines +43 to +44
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though dbt-core is no longer a functional dependency of adapters, we're going to keep including dbt-core in setup.py to prevent surprising/breaking changes to the behavior of pip install dbt-duckdb on the day of the v1.8 final release.

dbt-duck shouldn't import anything from dbt-core directly, only from the interfaces defined in dbt-core + dbt-adapters.

],
extras_require={"glue": ["boto3", "mypy-boto3-glue"], "md": ["duckdb>=0.7.0,<=0.9.2"]},
classifiers=[
Expand Down