Fix use after free in Main.cpp (issue yvt#846)

Create c-string to store filepath before concatenating with output message.
dtomlinson-ga · Nov 27, 2019 · 17cd56d · 17cd56d
1 parent 08e792e
commit 17cd56d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/Sources/Gui/Main.cpp b/Sources/Gui/Main.cpp
@@ -425,9 +425,8 @@ int main(int argc, char **argv) {
 						SDL_RWops *io = SDL_RWFromFile(
 						  (home + "/.openspades/CONTENT_MOVED_TO_NEW_DIR").c_str(), "wb");
 						if (io != NULL) {
-							const char *text = ("Content of this directory moved to " +
-							                    xdg_data_home + "/openspades")
-							                     .c_str();
+							const char *directory = (xdg_data_home + "/openspades").c_str();
+							const char *text = ("Content of this directory moved to " + directory).c_str();
 							io->write(io, text, strlen(text), 1);
 							io->close(io);
 						}