Add tests for workload update and install affecting rollback install …

…state
dsplaisted · May 3, 2024 · effb24f · effb24f
1 parent e8a3353
commit effb24f
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 12 deletions.
diff --git a/src/Tests/dotnet-MsiInstallation.Tests/Framework/VMTestBase.cs b/src/Tests/dotnet-MsiInstallation.Tests/Framework/VMTestBase.cs
@@ -179,5 +179,16 @@ protected WorkloadSet ParseRollbackOutput(string output)
 
             return WorkloadSet.FromJson(filteredOutput, defaultFeatureBand: new SdkFeatureBand(SdkInstallerVersion));
         }
+
+        protected string GetWorkloadVersion()
+        {
+            var result = VM.CreateRunCommand("dotnet", "workload", "--version")
+                .WithIsReadOnly(true)
+                .Execute();
+
+            result.Should().Pass();
+
+            return result.StdOut;
+        }
     }
 }
diff --git a/src/Tests/dotnet-MsiInstallation.Tests/MsiInstallerTests.cs b/src/Tests/dotnet-MsiInstallation.Tests/MsiInstallerTests.cs
@@ -197,7 +197,7 @@ public void UpdateWithRollback()
             InstallSdk();
             InstallWorkload("wasm-tools");
             ApplyRC1Manifests();
-            
+
             TestWasmWorkload();
 
             //  Second time applying same rollback file shouldn't do anything
@@ -220,6 +220,33 @@ public void InstallWithRollback()
             TestWasmWorkload();
         }
 
+        [Fact]
+        public void InstallShouldNotUpdatePinnedRollback()
+        {
+            InstallSdk();
+            ApplyRC1Manifests();
+            var workloadVersion = GetWorkloadVersion();
+
+            InstallWorkload("aspire");
+
+            GetWorkloadVersion().Should().Be(workloadVersion);
+        }
+
+        [Fact]
+        public void UpdateShouldUndoPinnedRollback()
+        {
+            InstallSdk();
+            ApplyRC1Manifests();
+            var workloadVersion = GetWorkloadVersion();
+
+            VM.CreateRunCommand("dotnet", "workload", "update")
+                .Execute()
+                .Should().Pass();
+
+            GetWorkloadVersion().Should().NotBe(workloadVersion);
+
+        }
+
         [Fact]
         public void ShouldNotShowRebootMessage()
         {

diff --git a/src/Tests/dotnet-MsiInstallation.Tests/WorkloadSetTests.cs b/src/Tests/dotnet-MsiInstallation.Tests/WorkloadSetTests.cs
@@ -213,17 +213,6 @@ public void UpdateToWorkloadSetVersionWithManifestsNotAvailable()
             GetWorkloadVersion().Should().Be(workloadVersionBeforeUpdate);
         }
 
-        string GetWorkloadVersion()
-        {
-            var result = VM.CreateRunCommand("dotnet", "workload", "--version")
-                .WithIsReadOnly(true)
-                .Execute();
-
-            result.Should().Pass();
-
-            return result.StdOut;
-        }
-
         string GetUpdateMode()
         {
             var result = VM.CreateRunCommand("dotnet", "workload", "config", "--update-mode")