ci: Build ARM images for core components (kubeflow#7220)

* ci: Build ARM images for core components Extend the GH Actions to also build the images on ARM architectures. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * crud-web-apps: Update python and gevent versions In order to successfully build on linux/arm64/v8 we'll need to: * Update to Python 3.10 * Bump the gevent version gevent/gevent#1721 (comment) * Update the workflows for JWA Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for centraldb Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for kfam Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for notebook-controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for PodDefaults Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for Profile Controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for pvcviewer controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for TensorBoard Controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for TWA Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for VWA Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update releasing script to include PVCViewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
droctothorpe · Oct 4, 2023 · 466d675 · 466d675
1 parent 845beef
commit 466d675
Show file tree

Hide file tree

Showing 32 changed files with 405 additions and 97 deletions.
diff --git a/.github/workflows/centraldb_docker_publish.yaml b/.github/workflows/centraldb_docker_publish.yaml
@@ -11,7 +11,7 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/centraldashboard
-  ARCH: linux/ppc64le,linux/amd64
+  ARCH: linux/ppc64le,linux/amd64,linux/arm64/v8
 
 jobs:
   push_to_registry:
@@ -33,7 +33,7 @@ jobs:
       with:
         username: ${{ env.DOCKER_USER }}
         password: ${{ secrets.KUBEFLOWNOTEBOOKSWG_DOCKER_TOKEN }}
-        
+
     - name: Setup QEMU
       uses: docker/setup-qemu-action@v2
 

diff --git a/.github/workflows/centraldb_intergration_test.yaml b/.github/workflows/centraldb_intergration_test.yaml
@@ -22,16 +22,12 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v3
 
-    - name: Setup QEMU
-      uses: docker/setup-qemu-action@v2
-
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
     - name: Build CentralDashboard Image
       run: |
         cd components/centraldashboard
-        ARCH=linux/ppc64le make docker-build-multi-arch
         ARCH=linux/amd64 make docker-build-multi-arch
 
     - name: Install KinD

diff --git a/.github/workflows/centraldb_multi_arch_test.yaml b/.github/workflows/centraldb_multi_arch_test.yaml
@@ -0,0 +1,35 @@
+name: CentralDashboard Multi-Arch Build Test
+on:
+  pull_request:
+    paths:
+      - components/centraldashboard/**
+    branches:
+      - master
+      - v*-branch
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
+  cancel-in-progress: true
+
+env:
+  IMG: centraldashboard
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Setup QEMU
+      uses: docker/setup-qemu-action@v2
+
+    - name: Setup Docker Buildx
+      uses: docker/setup-buildx-action@v2
+
+    - name: Build multi-arch Image
+      run: |
+        cd components/centraldashboard
+        ARCH=linux/ppc64le make docker-build-multi-arch
+        ARCH=linux/amd64 make docker-build-multi-arch
+        ARCH=linux/arm64/v8 make docker-build-multi-arch
diff --git a/.github/workflows/jwa_docker_publish.yaml b/.github/workflows/jwa_docker_publish.yaml
@@ -12,9 +12,7 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/jupyter-web-app
-  # If this is a PR, we ONLY build for AMD64. For PRs we only do a sanity check test to ensure Docker builds work.
-  # If this is NOT a PR (e.g. a tag or merge commit), also build for ppc64le.
-  ARCH: linux/amd64${{ github.event_name != 'pull_request' && ',linux/ppc64le' || '' }}
+  ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:
   push_to_registry:
@@ -42,13 +40,13 @@ jobs:
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
-    
+
     - name: Build and push multi-arch docker image
       run: |
         cd components/crud-web-apps/jupyter
         make docker-build-push-multi-arch
 
-    - name: Build and push latest multi-arch docker image 
+    - name: Build and push latest multi-arch docker image
       if: github.ref == 'refs/heads/master'
       run: |
         export TAG=latest

diff --git a/.github/workflows/jwa_intergration_test.yaml b/.github/workflows/jwa_intergration_test.yaml
@@ -22,26 +22,22 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v3
-
-    - name: Setup QEMU
-      uses: docker/setup-qemu-action@v2
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
-    - name: Build JWA Image 
+    - name: Build JWA Image
       run: |
         cd components/crud-web-apps/jupyter
-        ARCH=linux/ppc64le make docker-build-multi-arch
-        ARCH=linux/amd64 make docker-build-multi-arch 
+        make docker-build-multi-arch
 
     - name: Install KinD
       run: ./components/testing/gh-actions/install_kind.sh
 
     - name: Create KinD Cluster
       run: kind create cluster --config components/testing/gh-actions/kind-1-25.yaml
 
-    - name: Load Image into KinD Cluster 
+    - name: Load Image into KinD Cluster
       run: |
         kind load docker-image "${IMG}:${TAG}"
 

diff --git a/.github/workflows/jwa_multi_arch_test.yaml b/.github/workflows/jwa_multi_arch_test.yaml
@@ -0,0 +1,36 @@
+name: JWA Multi-Arch Build Test
+on:
+  pull_request:
+    paths:
+      - components/crud-web-apps/jupyter/**
+      - components/crud-web-apps/common/**
+    branches:
+      - master
+      - v*-branch
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
+  cancel-in-progress: true
+
+env:
+  IMG: jupyter-web-app
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Setup QEMU
+      uses: docker/setup-qemu-action@v2
+
+    - name: Setup Docker Buildx
+      uses: docker/setup-buildx-action@v2
+
+    - name: Build multi-arch Image
+      run: |
+        cd components/crud-web-apps/jupyter
+        ARCH=linux/ppc64le make docker-build-multi-arch
+        ARCH=linux/amd64 make docker-build-multi-arch
+        ARCH=linux/arm64/v8 make docker-build-multi-arch
diff --git a/.github/workflows/kfam_docker_publish.yaml b/.github/workflows/kfam_docker_publish.yaml
@@ -11,9 +11,7 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/kfam
-  # If this is a PR, we ONLY build for AMD64. For PRs we only do a sanity check test to ensure Docker builds work.
-  # If this is NOT a PR (e.g. a tag or merge commit), also build for ppc64le.
-  ARCH: linux/amd64${{ github.event_name != 'pull_request' && ',linux/ppc64le' || '' }}
+  ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:
   push_to_registry:

diff --git a/.github/workflows/kfam_multi_arch_test.yaml b/.github/workflows/kfam_multi_arch_test.yaml
@@ -0,0 +1,35 @@
+name: KFAM Multi-Arch Build Test
+on:
+  pull_request:
+    paths:
+      - components/access-management/**
+    branches:
+      - master
+      - v*-branch
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
+  cancel-in-progress: true
+
+env:
+  IMG: kfam
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Setup QEMU
+      uses: docker/setup-qemu-action@v2
+
+    - name: Setup Docker Buildx
+      uses: docker/setup-buildx-action@v2
+
+    - name: Build multi-arch Image
+      run: |
+        cd components/access-management
+        ARCH=linux/ppc64le make docker-build-multi-arch
+        ARCH=linux/amd64 make docker-build-multi-arch
+        ARCH=linux/arm64/v8 make docker-build-multi-arch
diff --git a/.github/workflows/nb_controller_docker_publish.yaml b/.github/workflows/nb_controller_docker_publish.yaml
@@ -12,9 +12,7 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/notebook-controller
-  # If this is a PR, we ONLY build for AMD64. For PRs we only do a sanity check test to ensure Docker builds work.
-  # If this is NOT a PR (e.g. a tag or merge commit), also build for ppc64le.
-  ARCH: linux/amd64${{ github.event_name != 'pull_request' && ',linux/ppc64le' || '' }}
+  ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:
   push_to_registry:
@@ -39,8 +37,6 @@ jobs:
 
     - name: Setup QEMU
       uses: docker/setup-qemu-action@v2
-      with:
-        platforms: ppc64le
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2

diff --git a/.github/workflows/nb_controller_intergration_test.yaml b/.github/workflows/nb_controller_intergration_test.yaml
@@ -21,26 +21,22 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v3
-
-    - name: Setup QEMU
-      uses: docker/setup-qemu-action@v2
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
-    - name: Build Notebook Controller Image 
+    - name: Build Notebook Controller Image
       run: |
         cd components/notebook-controller
-        ARCH=linux/ppc64le make docker-build-multi-arch
-        ARCH=linux/amd64 make docker-build-multi-arch
+        make docker-build-multi-arch
 
     - name: Install KinD
       run: ./components/testing/gh-actions/install_kind.sh
 
     - name: Create KinD Cluster
       run: kind create cluster --config components/testing/gh-actions/kind-1-25.yaml
 
-    - name: Load Images into KinD Cluster 
+    - name: Load Images into KinD Cluster
       run: |
         kind load docker-image "${IMG}:${TAG}"
 

diff --git a/.github/workflows/nb_controller_multi_arch_test.yaml b/.github/workflows/nb_controller_multi_arch_test.yaml
@@ -0,0 +1,35 @@
+name: Notebook Controller Multi-Arch Build Test
+on:
+  pull_request:
+    paths:
+      - components/notebook-controller/**
+    branches:
+      - master
+      - v*-branch
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
+  cancel-in-progress: true
+
+env:
+  IMG: notebook-controller
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Setup QEMU
+      uses: docker/setup-qemu-action@v2
+
+    - name: Setup Docker Buildx
+      uses: docker/setup-buildx-action@v2
+
+    - name: Build multi-arch Image
+      run: |
+        cd components/notebook-controller
+        ARCH=linux/ppc64le make docker-build-multi-arch
+        ARCH=linux/amd64 make docker-build-multi-arch
+        ARCH=linux/arm64/v8 make docker-build-multi-arch
diff --git a/.github/workflows/poddefaults_docker_publish.yaml b/.github/workflows/poddefaults_docker_publish.yaml
@@ -11,9 +11,7 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/poddefaults-webhook
-  # If this is a PR, we ONLY build for AMD64. For PRs we only do a sanity check test to ensure Docker builds work.
-  # If this is NOT a PR (e.g. a tag or merge commit), also build for ppc64le.
-  ARCH: linux/amd64${{ github.event_name != 'pull_request' && ',linux/ppc64le' || '' }}
+  ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:
   push_to_registry:

diff --git a/.github/workflows/poddefaults_intergration_test.yaml b/.github/workflows/poddefaults_intergration_test.yaml
@@ -21,27 +21,22 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v3
-
-    - name: Setup QEMU
-      uses: docker/setup-qemu-action@v2
 
     - name: Setup Docker Buildx
       uses: docker/setup-buildx-action@v2
 
-
-    - name: Build PodDefaults Image 
+    - name: Build PodDefaults Image
       run: |
         cd components/admission-webhook
-        ARCH=linux/ppc64le make docker-build-multi-arch
-        ARCH=linux/amd64 make docker-build-multi-arch
+        make docker-build-multi-arch
 
     - name: Install KinD
       run: ./components/testing/gh-actions/install_kind.sh
 
     - name: Create KinD Cluster
       run: kind create cluster --config components/testing/gh-actions/kind-1-25.yaml
 
-    - name: Load Images into KinD Cluster 
+    - name: Load Images into KinD Cluster
       run: |
         kind load docker-image "${IMG}:${TAG}"
 

diff --git a/.github/workflows/poddefaults_multi_arch_test.yaml b/.github/workflows/poddefaults_multi_arch_test.yaml
@@ -0,0 +1,35 @@
+name: PodDefaults Multi-Arch Build Test
+on:
+  pull_request:
+    paths:
+      - components/admission-webhook/**
+    branches:
+      - master
+      - v*-branch
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
+  cancel-in-progress: true
+
+env:
+  IMG: poddefaults-webhook
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Setup QEMU
+      uses: docker/setup-qemu-action@v2
+
+    - name: Setup Docker Buildx
+      uses: docker/setup-buildx-action@v2
+
+    - name: Build multi-arch Image
+      run: |
+        cd components/admission-webhook
+        ARCH=linux/ppc64le make docker-build-multi-arch
+        ARCH=linux/amd64 make docker-build-multi-arch
+        ARCH=linux/arm64/v8 make docker-build-multi-arch
diff --git a/.github/workflows/prof_controller_docker_publish.yaml b/.github/workflows/prof_controller_docker_publish.yaml
@@ -11,9 +11,7 @@ on:
 env:
   DOCKER_USER: kubeflownotebookswg
   IMG: kubeflownotebookswg/profile-controller
-  # If this is a PR, we ONLY build for AMD64. For PRs we only do a sanity check test to ensure Docker builds work.
-  # If this is NOT a PR (e.g. a tag or merge commit), also build for ppc64le.
-  ARCH: linux/amd64${{ github.event_name != 'pull_request' && ',linux/ppc64le' || '' }}
+  ARCH: linux/amd64,linux/ppc64le,linux/arm64/v8
 
 jobs:
   push_to_registry: