Skip to content

Commit

Permalink
Move root approvers to subdirs
Browse files Browse the repository at this point in the history
  • Loading branch information
liggitt committed Oct 10, 2022
1 parent b8b86bb commit dd09106
Show file tree
Hide file tree
Showing 9 changed files with 55 additions and 12 deletions.
18 changes: 6 additions & 12 deletions OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,18 @@

filters:
".*":
reviewers:
reviewers: []
approvers: []
emeritus_approvers:
- bgrant0607
- brendandburns
- dchen1107
- jbeda
- lavalamp
- smarterclayton
- thockin
- wojtek-t
- liggitt
approvers:
- dchen1107
- lavalamp
- smarterclayton
- thockin
- wojtek-t
- liggitt
emeritus_approvers:
- brendandburns
- bgrant0607
- jbeda
# go.{mod,sum} files relate to go dependencies, and should be reviewed by the
# dep-approvers
"go\\.(mod|sum)$":
Expand Down
4 changes: 4 additions & 0 deletions build/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ reviewers:
- jeremyrickard # SIG Technical Lead / RelEng subproject owner
#- justaugustus # SIG Chair / RelEng subproject owner / Release Manager - approvals only
- lavalamp
- liggitt
- palnabarun # Release Manager
- puerco # SIG Technical Lead / RelEng subproject owner / Release Manager
- saschagrunert # SIG Chair / RelEng subproject owner / Release Manager
- spiffxp
- thockin
- Verolop # Release Manager
- xmudrii # Release Manager
approvers:
Expand All @@ -23,8 +25,10 @@ approvers:
- dims
- justaugustus
- lavalamp
- liggitt
- mikedanese
- spiffxp
- thockin
emeritus_approvers:
- fejta
- jbeda
Expand Down
4 changes: 4 additions & 0 deletions cluster/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,18 @@ reviewers:
- cheftako
- dims
- justaugustus
- liggitt
- mikedanese
- spiffxp
- wojtek-t
approvers:
- bentheelder
- cheftako
- dims
- liggitt
- mikedanese
- spiffxp
- wojtek-t
emeritus_approvers:
- eparis
- roberthbailey # 2019-03-08
Expand Down
6 changes: 6 additions & 0 deletions cmd/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,17 @@ reviewers:
- dchen1107
- dims
- lavalamp
- liggitt
- mikedanese
- smarterclayton
- thockin
- wojtek-t
approvers:
- dchen1107
- dims
- lavalamp
- liggitt
- mikedanese
- smarterclayton
- thockin
- wojtek-t
9 changes: 9 additions & 0 deletions hack/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,22 @@ options:
reviewers:
- bentheelder
- cblecker
- dchen1107
- hwdef
- justaugustus
- lavalamp
- liggitt
- mikedanese
- SataQiu
- smarterclayton
- spiffxp
- sttts
- thockin
- wojtek-t
approvers:
- bentheelder
- cblecker
- dchen1107
- deads2k
- dims # for local-up-cluster related files
- enj # for sig-auth related stuff like cert testdata
Expand All @@ -24,9 +30,12 @@ approvers:
- mikedanese
- pwittrock
- SataQiu
- smarterclayton
- soltysh # for sig-cli related stuff
- spiffxp
- sttts
- thockin
- wojtek-t
emeritus_approvers:
- eparis
- fejta
Expand Down
4 changes: 4 additions & 0 deletions pkg/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@ reviewers:
- dchen1107
- dims
- lavalamp
- liggitt
- smarterclayton
- thockin
- wojtek-t
approvers:
- dchen1107
- dims
- lavalamp
- liggitt
- smarterclayton
- thockin
- wojtek-t
emeritus_approvers:
- brendandburns
6 changes: 6 additions & 0 deletions plugin/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,18 @@ reviewers:
- dchen1107
- dims
- lavalamp
- liggitt
- smarterclayton
- thockin
- wojtek-t
approvers:
- dchen1107
- dims
- lavalamp
- liggitt
- smarterclayton
- thockin
- wojtek-t
emeritus_approvers:
- davidopp
- brendandburns
6 changes: 6 additions & 0 deletions staging/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,22 @@ options:
# make root approval non-recursive
no_parent_owners: true
approvers:
- dchen1107
- dims
- lavalamp
- liggitt
- smarterclayton
- thockin
- wojtek-t
reviewers:
- caesarxuchao
- dchen1107
- deads2k
- dims
- lavalamp
- liggitt
- mikedanese
- smarterclayton
- sttts
- thockin
- wojtek-t
10 changes: 10 additions & 0 deletions test/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,28 @@ options:
no_parent_owners: true
reviewers:
- aojea
- dchen1107
- johnSchnake
- lavalamp
- liggitt
- neolit123
- SataQiu
- smarterclayton
- thockin
- wojtek-t
approvers:
- andrewsykim
- aojea
- BenTheElder
- bowei # for test/e2e/{dns*,network}.go
- caseydavenport # for test/e2e/{dns*,network}.go
- cblecker
- dchen1107
- deads2k
- dims
- enj
- janetkuo
- lavalamp
- liggitt
- mikedanese
- MrHohn
Expand All @@ -32,6 +40,8 @@ approvers:
- smarterclayton
- soltysh
- sttts
- thockin
- wojtek-t
emeritus_approvers:
- eparis
- foxish
Expand Down

0 comments on commit dd09106

Please sign in to comment.