forked from kubernetes/kubernetes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request kubernetes#115813 from atiratree/controller-aliases
Introduce controller aliases for KCM and CCM
- Loading branch information
Showing
27 changed files
with
1,035 additions
and
285 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| /* | ||
| Copyright 2023 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package app | ||
|
|
||
| import ( | ||
| "regexp" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "k8s.io/apimachinery/pkg/util/sets" | ||
| cpnames "k8s.io/cloud-provider/names" | ||
|
|
||
| "k8s.io/kubernetes/cmd/kube-controller-manager/names" | ||
| ) | ||
|
|
||
| func TestControllerNamesConsistency(t *testing.T) { | ||
| controllerNameRegexp := regexp.MustCompile("^[a-z]([-a-z]*[a-z])?$") | ||
|
|
||
| for _, name := range KnownControllers() { | ||
| if !controllerNameRegexp.MatchString(name) { | ||
| t.Errorf("name consistency check failed: controller %q must consist of lower case alphabetic characters or '-', and must start and end with an alphabetic character", name) | ||
| } | ||
| if !strings.HasSuffix(name, "-controller") { | ||
| t.Errorf("name consistency check failed: controller %q must have \"-controller\" suffix", name) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestControllerNamesDeclaration(t *testing.T) { | ||
| declaredControllers := sets.New( | ||
| names.ServiceAccountTokenController, | ||
| names.EndpointsController, | ||
| names.EndpointSliceController, | ||
| names.EndpointSliceMirroringController, | ||
| names.ReplicationControllerController, | ||
| names.PodGarbageCollectorController, | ||
| names.ResourceQuotaController, | ||
| names.NamespaceController, | ||
| names.ServiceAccountController, | ||
| names.GarbageCollectorController, | ||
| names.DaemonSetController, | ||
| names.JobController, | ||
| names.DeploymentController, | ||
| names.ReplicaSetController, | ||
| names.HorizontalPodAutoscalerController, | ||
| names.DisruptionController, | ||
| names.StatefulSetController, | ||
| names.CronJobController, | ||
| names.CertificateSigningRequestSigningController, | ||
| names.CertificateSigningRequestApprovingController, | ||
| names.CertificateSigningRequestCleanerController, | ||
| names.TTLController, | ||
| names.BootstrapSignerController, | ||
| names.TokenCleanerController, | ||
| names.NodeIpamController, | ||
| names.NodeLifecycleController, | ||
| cpnames.ServiceLBController, | ||
| cpnames.NodeRouteController, | ||
| cpnames.CloudNodeLifecycleController, | ||
| names.PersistentVolumeBinderController, | ||
| names.PersistentVolumeAttachDetachController, | ||
| names.PersistentVolumeExpanderController, | ||
| names.ClusterRoleAggregationController, | ||
| names.PersistentVolumeClaimProtectionController, | ||
| names.PersistentVolumeProtectionController, | ||
| names.TTLAfterFinishedController, | ||
| names.RootCACertificatePublisherController, | ||
| names.EphemeralVolumeController, | ||
| names.StorageVersionGarbageCollectorController, | ||
| names.ResourceClaimController, | ||
| names.LegacyServiceAccountTokenCleanerController, | ||
| ) | ||
|
|
||
| for _, name := range KnownControllers() { | ||
| if !declaredControllers.Has(name) { | ||
| t.Errorf("name declaration check failed: controller name %q should be declared in \"controller_names.go\" and added to this test", name) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.