Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

User interface leaves a lot to be desired #200

Closed
jeffhtu opened this issue Jan 30, 2019 · 7 comments
Closed

User interface leaves a lot to be desired #200

jeffhtu opened this issue Jan 30, 2019 · 7 comments
Labels
enhancement help wanted

Comments

@jeffhtu
Copy link

jeffhtu commented Jan 30, 2019 •
edited
Loading

I was excited to find this "reference" code, hoping to learn the proper coding techniques. Upon running the app, I have to say I'm somewhat disappointed the UI looks so...amateurish. The header with stacked "My orders", "My account", "Log out", and the unusually tall footer with text that's not even centered. I suppose the UI is not the focal point of this sample, but still...

Is there anything I can do to help? :-)
@ardalis
Copy link
Collaborator

ardalis commented Jan 30, 2019

Cleaning up the header UI has been on the backlog for a while (when logged in, it's way too tall). We would certainly welcome any PRs with UI improvements. Ideally keep them to one thing per PR so we can quickly review and implement them. Thanks!

@efleming18
Copy link
Collaborator

I've started to fix up the header and a few other styles as well.
#201
#202
Will continue making some improvements this week.

@efleming18
Copy link
Collaborator

@efleming18
Copy link
Collaborator

Fixed the footer styling on the login page, checkout page, and any other page with less content on the screen in this PR.
#210

@efleming18
Copy link
Collaborator

Fixed the pager styles as well #215

@efleming18
Copy link
Collaborator

Updated the filter button styles #225

@efleming18
Copy link
Collaborator

I believe all of the above changes improved the UI to the point where any further updates should be new, separate issues.

@dependabot dependabot bot mentioned this issue Feb 12, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ardalis @efleming18 @jeffhtu