Add setting to control Razor component commit behaviour #6506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Oct 9, 2023
Resolves the "we did not find firm opinions" part of #8295 by introducing an option to allow users to control how they want completion for html elements, tag helper elements and components to behave. Corresponding VS Code PR: dotnet/vscode-csharp#6506
davidwengier
commented
Oct 10, 2023
| "NEW_DEPS_URLS": "https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/f0e050f69a2afb6758a1bccfbf00bb9a/razorlanguageserver-linux-arm64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/e3d3993005c037451c715c26ec43328b/razorlanguageserver-linux-musl-arm64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/c3fd7144ecc6abea28e905504a60d65b/razorlanguageserver-linux-musl-x64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/98abba355a15ad90c59eb5653326baeb/razorlanguageserver-linux-x64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/68cd5916dbff0936c04ae0a152268d0f/razorlanguageserver-osx-arm64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/f13124670d3c1f52ecbeb79538d763cb/razorlanguageserver-osx-x64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/d50e57f6a69f75a65496f32b107532e8/razorlanguageserver-win-arm64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/70a917c8a17f4052a3a6b3862200f9f5/razorlanguageserver-win-x64-7.0.0-preview.23475.5.zip,https://download.visualstudio.microsoft.com/download/pr/baaea3c9-bcff-4331-9fd2-fee91ddbfccb/ee48f10fa72517ce132fad30d458680a/razorlanguageserver-win-x86-7.0.0-preview.23475.5.zip", | ||
| "NEW_DEPS_VERSION": "7.0.0-preview.23475.5", | ||
| "NEW_DEPS_URLS": "https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/59e252ec1565aa1e72aab4df73f35510/razorlanguageserver-linux-arm64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/565066c5ca0844edb90b66187e99bd03/razorlanguageserver-linux-musl-arm64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/c2c5dbc26f3ad91ac851ce175abb57e1/razorlanguageserver-linux-musl-x64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/7c1e301d9000f06debecc8208d7aa2ea/razorlanguageserver-linux-x64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/7b231eee6608879bc934a8256324e9f5/razorlanguageserver-osx-arm64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/101e1db25b9411892eb6474c516a38b4/razorlanguageserver-osx-x64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/59830fe8f7d57758675cc36f48b65a29/razorlanguageserver-win-arm64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/22969b5b81fda9d5f5403b6cef265058/razorlanguageserver-win-x64-7.0.0-preview.23509.2.zip,https://download.visualstudio.microsoft.com/download/pr/2ec8c3c2-4f6f-42c0-8c90-97fd97427d7c/5fe01999736b69133fa1ea97fb35aed2/razorlanguageserver-win-x86-7.0.0-preview.23509.2.zip", | ||
| "NEW_DEPS_VERSION": "7.0.0-preview.23509.2", |
There was a problem hiding this comment.
@allisonchou is it cool to just update the server? or do I need to update the telemetry too? Before this change, they were on the same version.
There was a problem hiding this comment.
I haven't tried updating just the server before so I'm not 100% sure, but I think updating solely the server should be fine as long as there are no telemetry-specific changes. I would verify there are no problems when opening a Razor file just to be sure though
There was a problem hiding this comment.
Opening razor files works fine, and i don't see the word "telemetry" in any worrying places in the Razor log, so I'm going to assume this all works 😁
allisonchou
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side is dotnet/razor#9379
Will bump Razor in this PR before merging