Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide the package manager into separate components #2188

Merged
merged 66 commits into from
Apr 24, 2018
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
6205e1d
use async await
akshita31 Apr 10, 2018
c632ab2
async await
akshita31 Apr 10, 2018
01f8cb1
remove promise
akshita31 Apr 10, 2018
56675b9
remove packagejson
akshita31 Apr 10, 2018
19ee685
resolve conflicts
akshita31 Apr 10, 2018
400ba5e
Feature tests running with refactored package manager
akshita31 Apr 10, 2018
5c4bfc0
trial to mock server
akshita31 Apr 11, 2018
3968900
package add
akshita31 Apr 11, 2018
cbf50af
package manager test not running
akshita31 Apr 11, 2018
8c09369
Mocking the server running
akshita31 Apr 11, 2018
c74aecf
Refactoring packages-1
akshita31 Apr 12, 2018
3e58f13
Test for the downloader running using the mock server
akshita31 Apr 13, 2018
5565a2e
Using network settings
akshita31 Apr 13, 2018
c8135b5
Changing the package path
akshita31 Apr 13, 2018
9afc874
Dividing packages.ts into separate components
akshita31 Apr 13, 2018
9cc0016
modification for network settings
akshita31 Apr 13, 2018
98e7e74
Clean up the downloaders
akshita31 Apr 13, 2018
e20a434
launch.json
akshita31 Apr 13, 2018
97e83ec
Clean up
akshita31 Apr 13, 2018
e7b520a
do not use filter
akshita31 Apr 13, 2018
c6bee5a
use filter async
akshita31 Apr 13, 2018
2dac16c
Use tmp file interface
akshita31 Apr 13, 2018
85d867f
Use tmpfile interface
akshita31 Apr 13, 2018
348e03a
merge master
akshita31 Apr 13, 2018
57d4bff
Check for the event stream
akshita31 Apr 14, 2018
9afa848
package json
akshita31 Apr 14, 2018
e5b0d65
Changes
akshita31 Apr 16, 2018
7e77a6e
Using FilePathResolver
akshita31 Apr 16, 2018
76e9780
Remove using
akshita31 Apr 16, 2018
47a18d1
Testing for normal and fallback case working
akshita31 Apr 16, 2018
441153a
Resolve the paths
akshita31 Apr 16, 2018
df2f874
Remove failing case
akshita31 Apr 16, 2018
4c2c15c
package installer test-1
akshita31 Apr 17, 2018
7e44a06
Add package installer test
akshita31 Apr 17, 2018
e218cb4
Create tmp asset
akshita31 Apr 17, 2018
b96fb22
Package Downloader test refactored
akshita31 Apr 17, 2018
10b6073
Rename files
akshita31 Apr 17, 2018
b9ac792
resolve compile issues
akshita31 Apr 17, 2018
10c6811
Clean up installer
akshita31 Apr 17, 2018
053efe3
Clean up the tests
akshita31 Apr 17, 2018
286fa7c
Nits
akshita31 Apr 18, 2018
12dfc3f
Rename packages
akshita31 Apr 18, 2018
24a5c03
Package installer test
akshita31 Apr 18, 2018
9e26124
PR feedback
akshita31 Apr 18, 2018
bccfa13
Package Filter test
akshita31 Apr 19, 2018
2b6ba72
Remove yauzl.d.ts
akshita31 Apr 19, 2018
7b2586f
Filter test
akshita31 Apr 19, 2018
df111f6
Added test for invalid zip file
akshita31 Apr 19, 2018
3ff44bb
method for getting the request options
akshita31 Apr 19, 2018
ebe6a2a
remove imports
akshita31 Apr 19, 2018
3a97968
please resolve the path
akshita31 Apr 20, 2018
93ea65c
remove latest in settings
akshita31 Apr 20, 2018
cc4a782
trial for travis
akshita31 Apr 20, 2018
13ad87d
Test run
akshita31 Apr 20, 2018
a6ed9a0
Package Manager test executing
akshita31 Apr 21, 2018
fdc9e0c
Use free port in package manager test
akshita31 Apr 21, 2018
16e1c88
Package Manager (using a https server running)
akshita31 Apr 23, 2018
1fe14a5
using http mock server
akshita31 Apr 23, 2018
bde8b49
Downloader test running using free port
akshita31 Apr 23, 2018
7abd6a6
Nits
akshita31 Apr 23, 2018
3e323af
clean up
akshita31 Apr 24, 2018
41b7b87
Making fallback url optional
akshita31 Apr 24, 2018
28fab5a
using else if
akshita31 Apr 24, 2018
45300ac
PR feedback
akshita31 Apr 24, 2018
573ca83
Package Error
akshita31 Apr 24, 2018
87fff8b
dispose if present
akshita31 Apr 24, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
using else if
  • Loading branch information
akshita31 committed Apr 24, 2018
commit 28fab5a1d8e533e068c581fa3f4e25768613a90f
2 changes: 1 addition & 1 deletion src/packageManager/FileDownloader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ async function downloadFile(fd: number, description: string, urlString: string,
return resolve(downloadFile(fd, description, response.headers.location, eventStream, networkSettingsProvider));
}

if (response.statusCode != 200) {
else if (response.statusCode != 200) {
// Download failed - print error message
eventStream.post(new DownloadFailure(`failed (error code '${response.statusCode}')`));
return reject(new NestedError(response.statusCode.toString()));
Expand Down