-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new DotNetBuildAllRuntimePacks property in dotnet/runtime build to collapse legs #45932
Draft
jkoritzinsky
wants to merge
12
commits into
dotnet:main
Choose a base branch
from
jkoritzinsky:vmr-build-all-runtime-packs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use the new DotNetBuildAllRuntimePacks property in dotnet/runtime build to collapse legs #45932
jkoritzinsky
wants to merge
12
commits into
dotnet:main
from
jkoritzinsky:vmr-build-all-runtime-packs
+482
−488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run sdk-unified-build-full |
Azure Pipelines successfully started running 1 pipeline(s). |
…remove 36 VMR legs. Remove support for the following properties as we no longer have separate ShortStack legs for them: - DotNetBuildRuntimeNativeAOTRuntimePack - DotNetBuildMonoCrossAOT Continue to support DotNetBuildUseMonoRuntime to specify mono-only builds as that will still be used by the Mono LLVMAOT VMR legs and we can still use it to validate Mono-only SB targets on non-Mono-only systems (ie validate the s390x build experience on x64)
jkoritzinsky
force-pushed
the
vmr-build-all-runtime-packs
branch
from
January 13, 2025 22:51
6ac3a58
to
1ffaaf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can remove 36 VMR legs.
Remove support for the following properties as we no longer have separate ShortStack legs for them:
Continue to support DotNetBuildUseMonoRuntime to specify mono-only builds as that will still be used by the Mono LLVMAOT VMR legs and we can still use it to validate Mono-only SB targets on non-Mono-only systems (ie validate the s390x build experience on x64)