Enable SB stage 2 builds in PR validation #45865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| buildSourceOnly: true # ✅ | ||
| enablePoison: false # 🚫 | ||
| excludeOmniSharpTests: true # ✅ | ||
| runOnline: true # ✅ |
There was a problem hiding this comment.
We would get more value by having an offline leg in PR validation. I know there was reasons this was configured to be online but I think those are somewhat mitigated by having this leg enabled in PR validation as it will eliminate the majority off offline regressions. Thoughts on making this offline?
There was a problem hiding this comment.
Yep, makes sense to me. Fixed
MichaelSimons
approved these changes
Jan 10, 2025
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3564