-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25057.1 #45749
Conversation
References a custom tarball with Microsoft.NETCore.App.Ref.9.0.0 SBRP removed
One of the repos that's failing to build for Unified Build is aspnetcore with the following error:
This only fails on Windows legs (it's not related to source build). Here's a binlog: aspnetcore.Build.repotasks.zip And a build link. It's not clear to me what the cause of this is. Pinging @wtgodbe |
@rainersigwald you might have an idea. This happens when building aspnetcore with desktop msbuild, the first time that NuGet assemblies are loaded. NuGet references STJ/8.0.0.5 and msbuild.exe 17.12.3+4ae11fa8e is being used. |
Could it be related to this change: dotnet/msbuild#11124 |
This went into the vs17.10 branch. CI uses VS 17.12 / msbuild 17.12.3 (dotnet/msbuild@4ae11fa as its HEAD). That one is unfortunately missing dotnet/msbuild@eacead3 which is required for STJ/8.0.0.5. |
I think this change caused the mismatch: NuGet/NuGet.Client@8791d42 |
That makes sense but GA 17.12 should have always had 8.0.0.5. However from the binlog:
That |
I think that the NuGet team's decision to update to STJ/8.0.0.5 was correct at that time. Our build images are just lagging behind way too much. The According to https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng%20Services%20Wiki/899/VS2022-Upgrade-Schedule, Fortunately, the image should get updated today. |
Agreed, I believe it went into their 17.13 branch so "assume GA 17.12" feels fine to me. |
src/SourceBuild/patches/winforms/0001-Fix-code-analysis-issues.patch
Outdated
Show resolved
Hide resolved
@ViktorHofer - Now we're getting this for aspnetcore:
|
This affects all VMR builds right now. See #45822 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going in :)
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25057.1
Fixes dotnet/source-build#4815