Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25057.1 #45749

Merged
merged 23 commits into from
Jan 9, 2025

Conversation

dotnet-sb-bot
Copy link
Contributor

@dotnet-sb-bot dotnet-sb-bot commented Jan 7, 2025

Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25057.1

Fixes dotnet/source-build#4815

@dotnet-sb-bot dotnet-sb-bot requested review from a team as code owners January 7, 2025 15:24
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 7, 2025
References a custom tarball with Microsoft.NETCore.App.Ref.9.0.0 SBRP removed
@mthalman
Copy link
Member

mthalman commented Jan 8, 2025

One of the repos that's failing to build for Unified Build is aspnetcore with the following error:

D:\a\_work\1\vmr\.dotnet\sdk\10.0.100-alpha.1.25056.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1060: Error reading assets file: Error loading lock file 'D:\a\_work\1\vmr\src\aspnetcore\artifacts\obj\RepoTasks\project.assets.json' : Could not load file or assembly 'System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. [D:\a\_work\1\vmr\src\aspnetcore\eng\tools\RepoTasks\RepoTasks.csproj]

This only fails on Windows legs (it's not related to source build).

Here's a binlog: aspnetcore.Build.repotasks.zip

And a build link.

It's not clear to me what the cause of this is. Pinging @wtgodbe

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 8, 2025

D:\a_work\1\vmr.dotnet\sdk\10.0.100-alpha.1.25056.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1060: Error reading assets file: Error loading lock file 'D:\a_work\1\vmr\src\aspnetcore\artifacts\obj\RepoTasks\project.assets.json' : Could not load file or assembly 'System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. [D:\a_work\1\vmr\src\aspnetcore\eng\tools\RepoTasks\RepoTasks.csproj]

@rainersigwald you might have an idea. This happens when building aspnetcore with desktop msbuild, the first time that NuGet assemblies are loaded. NuGet references STJ/8.0.0.5 and msbuild.exe 17.12.3+4ae11fa8e is being used.

@mthalman
Copy link
Member

mthalman commented Jan 8, 2025

D:\a_work\1\vmr.dotnet\sdk\10.0.100-alpha.1.25056.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1060: Error reading assets file: Error loading lock file 'D:\a_work\1\vmr\src\aspnetcore\artifacts\obj\RepoTasks\project.assets.json' : Could not load file or assembly 'System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. [D:\a_work\1\vmr\src\aspnetcore\eng\tools\RepoTasks\RepoTasks.csproj]

@rainersigwald you might have an idea. This happens when building aspnetcore with desktop msbuild, the first time that NuGet assemblies are loaded. NuGet references STJ/8.0.0.5 and msbuild.exe 17.12.3+4ae11fa8e is being used.

Could it be related to this change: dotnet/msbuild#11124

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 8, 2025

Could it be related to this change: dotnet/msbuild#11124

This went into the vs17.10 branch. CI uses VS 17.12 / msbuild 17.12.3 (dotnet/msbuild@4ae11fa as its HEAD). That one is unfortunately missing dotnet/msbuild@eacead3 which is required for STJ/8.0.0.5.

@ViktorHofer
Copy link
Member

I think this change caused the mismatch: NuGet/NuGet.Client@8791d42

cc @zivkan @marcpopMSFT

@rainersigwald
Copy link
Member

That makes sense but GA 17.12 should have always had 8.0.0.5. However from the binlog:

Assembly loaded during Evaluation: System.Text.Json, Version=8.0.0.4, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (location: C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\System.Text.Json.dll, MVID: d267e778-f3b7-48d4-a754-4adb2eeb2095, AppDomain: [Default])

That Preview makes me wonder if this is an old preview before that change? Do we know the exact VS version on the machine?

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 8, 2025

I think that the NuGet team's decision to update to STJ/8.0.0.5 was correct at that time. Our build images are just lagging behind way too much. The windows.vs2022preview.amd64.open image has a 3-months old version of msbuild installed.

According to https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng%20Services%20Wiki/899/VS2022-Upgrade-Schedule, windows.vs2022preview.amd64.open should have VS 17.13.0 Preview 1 installed but https://helix.dot.net/ mentions Preview 17.12.0-pre.4 and CI shows that the installed VS version is definitely not 17.13.0 Preview 1. @ilyas1974 @mmitche

Fortunately, the image should get updated today.

@rainersigwald
Copy link
Member

I think that the NuGet team's decision to update to STJ/8.0.0.5 was correct at that time.

Agreed, I believe it went into their 17.13 branch so "assume GA 17.12" feels fine to me.

@mthalman
Copy link
Member

mthalman commented Jan 9, 2025

@ViktorHofer - Now we're getting this for aspnetcore:

Unable to find directory for jdk 11.0.24%3B please make sure the tool is installed on this image.

@ViktorHofer
Copy link
Member

This affects all VMR builds right now. See #45822

@mthalman mthalman enabled auto-merge (squash) January 9, 2025 14:47
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going in :)

@mthalman mthalman merged commit 395a034 into main Jan 9, 2025
36 checks passed
@mthalman mthalman deleted the jan2025-source-build-1736263278 branch January 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline builds failing Unable to find package Microsoft.NETCore.App.Ref 9.0.0
5 participants