Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet-watch] Microsoft.DotNet.HotReload.Agent.PipeRpc source package #45603

Merged
merged 5 commits into from
Jan 11, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Dec 21, 2024

Factors named pipe RPC code to a source package sharable across dotnet-watch, Microsoft.Extensions.DotNetDeltaApplier and WebTool VS client.

The package targets netstandard2.0 to support VS in-proc client.

@tmat
Copy link
Member Author

tmat commented Jan 10, 2025

@phil-allen-msft PTAL

@phil-allen-msft
Copy link
Contributor

I'm not certain of the right place, but with the idea that different versions of VS can use different versions of the SDK and different versions of the runtime, is there some 'writeup/comments' necessary to explain how the use of the source package will make this easier to maintain?

@tmat tmat merged commit 7002321 into dotnet:release/9.0.2xx Jan 11, 2025
28 of 31 checks passed
@tmat tmat deleted the PipeRpc branch January 11, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants