Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode manifest name when building source-only #45554

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Hardcode manifest name when building source-only #45554

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d9ca68
Hardcode manifest name when building source-only
ViktorHofer Dec 18, 2024
1471e1e
Add condition to MergedAssetManifestName property
ViktorHofer Dec 18, 2024
049b240
Don't publish vertical manifest in source-only builds
ViktorHofer Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Hardcode manifest name when building source-only 
Fixes dotnet/source-build#4807
  • Loading branch information
@ViktorHofer
ViktorHofer authored Dec 18, 2024
commit 9d9ca68c2d6511a93b2a38d084cc4b7c60e16e71
8 changes: 6 additions & 2 deletions src/SourceBuild/content/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,12 @@
</PropertyGroup>

<PropertyGroup>
<!-- Respect the VerticalName property which is set to a unique identifier in CI. Otherwise default to 'VerticalManifest'. -->
<MergedAssetManifestOutputPath>$(ArtifactsAssetManifestsDir)$([MSBuild]::ValueOrDefault('$(VerticalName)', 'VerticalManifest')).xml</MergedAssetManifestOutputPath>
<!-- Respect the VerticalName property which is set to a unique identifier in CI.
Don't use that when building source-only to allow the build to find the previously built manifest file regardless of the vertical name.
Default to VerticalManifest.xml. -->
<MergedAssetManifestName>$(VerticalName).xml</MergedAssetManifestName>
<MergedAssetManifestName Condition="'$(DotNetBuildSourceOnly)' == 'true' or '$(MergedAssetManifestName)' == ''">VerticalManifest.xml</MergedAssetManifestName>
<MergedAssetManifestOutputPath>$(ArtifactsAssetManifestsDir)$(MergedAssetManifestName)</MergedAssetManifestOutputPath>
</PropertyGroup>

</Project>
Loading