Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE} Skip a few tests on osx #45419

Draft
wants to merge 10 commits into
base: release/9.0.2xx
Choose a base branch
from
Draft

[DO NOT MERGE} Skip a few tests on osx #45419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
af4edd6
Skip a few tests on osx
Forgind Dec 11, 2024
8fd4ae4
Comment instead of skip
Forgind Dec 12, 2024
9e81c68
Comment one more
Forgind Dec 13, 2024
650977e
Delete Build tests
Forgind Dec 21, 2024
1f681aa
Delete Publish tests
Forgind Dec 23, 2024
46d7ca9
Merge branch 'release/9.0.2xx' of https://github.com/dotnet/sdk into …
Forgind Dec 23, 2024
bd09f6f
Comment out two more tests
Forgind Dec 23, 2024
df6513e
Disable another
Forgind Dec 24, 2024
7fee15a
Eliminate another test
Forgind Dec 30, 2024
beef140
Disable one more
Forgind Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comment instead of skip
  • Loading branch information
@Forgind
Forgind committed Dec 12, 2024
commit 8fd4ae43ccf8b61529baca86353b3047bf24986d
3 changes: 2 additions & 1 deletion test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishReadyToRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ public void It_supports_libraries_when_using_crossgen2(string targetFramework)
publishCommand.Execute().Should().Pass();
}

/*
[RequiresMSBuildVersionTheory("17.0.0.32901")]
[SkipOnPlatform(TestPlatforms.OSX, "sadness")]
[InlineData(ToolsetInfo.CurrentTargetFramework, "linux-x64", "windows,linux,osx", "X64,Arm64", "_", "_")]
[InlineData(ToolsetInfo.CurrentTargetFramework, "linux-x64", "windows,linux,osx", "X64,Arm64", "composite", "selfcontained")] // Composite in .NET 6.0 is only supported for self-contained builds
// In .NET 6.0 building targeting Windows on linux or osx doesn't support emitting native symbols.
Expand Down Expand Up @@ -292,6 +292,7 @@ public void It_supports_crossos_arch_compilation(string targetFramework, string

TestProjectPublishing_Internal(projectName, targetFramework, isSelfContained: selfcontained == "selfcontained", emitNativeSymbols: true, useCrossgen2: true, composite: composite == "composite", identifier: targetFramework, runtimeIdentifier: runtimeIdentifier);
}
*/

private enum TargetOSEnum
{
Expand Down
3 changes: 2 additions & 1 deletion test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ public void Publish_WithDefaultSettings_Works()
VerifyTypeGranularTrimming(blazorPublishDirectory);
}

/*
[Fact]
[SkipOnPlatform(TestPlatforms.OSX, "sadness")]
public void Publish_Works_WithLibraryUsingHintPath()
{
// Arrange
Expand Down Expand Up @@ -156,6 +156,7 @@ public void Publish_Works_WithLibraryUsingHintPath()

new FileInfo(Path.Combine(publishOutputDirectory, "wwwroot", "_framework", "RazorClassLibrary.wasm")).Should().Exist();
}
*/

[Fact]
public void Publish_WithScopedCss_Works()
Expand Down
3 changes: 2 additions & 1 deletion test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestfromCsproj.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,8 +609,8 @@ public void ItShouldShowWarningMessageOnCollectCodeCoverage()
result.ExitCode.Should().Be(0);
}

/*
[Fact]
[SkipOnPlatform(TestPlatforms.OSX, "sadness")]
public void ItShouldShowImportantMessage()
{
string testAppName = "VSTestCore";
Expand All @@ -634,6 +634,7 @@ public void ItShouldShowImportantMessage()

result.ExitCode.Should().Be(1);
}
*/

[Fact]
public void ItSetsDotnetRootToTheLocationOfDotnetExecutableWhenRunningDotnetTestWithProject()
Expand Down
2 changes: 2 additions & 0 deletions test/dotnet.Tests/TelemetryCommonPropertiesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ public void TelemetryCommonPropertiesShouldContainLibcReleaseAndVersion()
}
}

/*
[Theory]
[MemberData(nameof(CITelemetryTestCases))]
public void CanDetectCIStatusForEnvVars(Dictionary<string, string> envVars, bool expected)
Expand All @@ -181,6 +182,7 @@ public void CanDetectCIStatusForEnvVars(Dictionary<string, string> envVars, bool
}
}
}
*/

public static IEnumerable<object[]> CITelemetryTestCases => new List<object[]>{
new object[] { new Dictionary<string, string> { { "TF_BUILD", "true" } }, true },
Expand Down
Loading