Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all StrBegin comments to be StrBegins to correctly show up in the… #43264

Merged
merged 2 commits into from
Sep 10, 2024
+6,810 −6,810
Merged

Fix all StrBegin comments to be StrBegins to correctly show up in the… #43264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89e733e
Fix all StrBegin comments to be StrBegins to correctly show up in the…
marcpopMSFT Sep 6, 2024
b9a6d7b
Fix test for StrBegins
marcpopMSFT Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test for StrBegins
  • Loading branch information
@marcpopMSFT
marcpopMSFT authored Sep 6, 2024
commit b9a6d7bef75624d31aae5f17a36ca45995828bc0
4 changes: 2 additions & 2 deletions src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenThatWeHaveErrorCodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,13 @@ public void ResxIsCommentedWithCorrectStrBegin()

if (name.EndsWith("_Info"))
{
comment.Should().NotContain("StrBegin",
comment.Should().NotContain("StrBegins",
because: "informational messages should not have error codes.");
}
else if (!_infoExceptions.Contains(name))
{

comment.Should().StartWith($@"{{StrBegin=""{prefix} ""}}",
comment.Should().StartWith($@"{{StrBegins=""{prefix} ""}}",
because: $"localization instructions should indicate invariant error code as preceding translatable message.");
}
}
Expand Down
Loading