Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In BrowserScriptMiddleware, dispose GetManifestResourceStream() #41634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

In BrowserScriptMiddleware, dispose GetManifestResourceStream() #41634

wants to merge 1 commit into from

Conversation

omajid
Copy link
Member

@omajid omajid commented Jun 17, 2024

We are disposing the MemoryStream in the previous line, so we should Dispose this too.

@omajid
In BrowserScriptMiddleware, dispose GetManifestResourceStream()
0dd3abf 
We are disposing the MemoryStream in the previous line, so we should
Dispose this too.
@omajid omajid requested a review from a team as a code owner June 17, 2024 15:13
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Jun 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @omajid.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omajid