Skip to content

Commit

Permalink
add Digest null value to test scenario that was missed
Browse files Browse the repository at this point in the history
  • Loading branch information
baronfel authored and BeyondEvil committed Dec 20, 2024
1 parent 0324adb commit e95d9ee
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public static async Task StartAndPopulateDockerRegistry(ITestOutputHelper testOu
string dotnetdll = System.Reflection.Assembly.GetExecutingAssembly().Location;
var ridjson = Path.Combine(Path.GetDirectoryName(dotnetdll)!, "RuntimeIdentifierGraph.json");

var image = await pullRegistry.GetImageManifestAsync(RuntimeBaseImage, tag, "linux-x64", new SameArchManifestPicker(), CancellationToken.None);
var image = await pullRegistry.GetImageManifestAsync(RuntimeBaseImage, tag, "linux-x64", new SameArchManifestPicker(), CancellationToken.None);
var source = new SourceImageReference(pullRegistry, RuntimeBaseImage, tag, null);
var dest = new DestinationImageReference(pushRegistry, RuntimeBaseImage, [tag]);
logger.LogInformation($"Pushing image for {BaseImageSource}/{RuntimeBaseImage}:{tag}");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public async Task TarballsHaveCorrectStructure()
BuiltImage builtImage = imageBuilder.Build();

// Write the image to disk
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net7ImageTag);
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net7ImageTag, null);
var destinationReference = new DestinationImageReference(new ArchiveFileRegistry(archiveFile), NewImageName(), tags);

return (builtImage, sourceReference, destinationReference);
Expand Down Expand Up @@ -1214,11 +1214,7 @@ public async Task CanPackageForAllSupportedContainerRIDs(string dockerPlatform,
BuiltImage builtImage = imageBuilder.Build();

// Load the image into the local registry
<<<<<<< HEAD
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net9ImageTag);
=======
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net9PreviewImageTag, null);
>>>>>>> 809df5c609 (Add support for using Digest for base image)
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net9ImageTag, null);
var destinationReference = new DestinationImageReference(registry, NewImageName(), new[] { rid });
await new DockerCli(_loggerFactory).LoadAsync(builtImage, sourceReference, destinationReference, default).ConfigureAwait(false);

Expand Down

0 comments on commit e95d9ee

Please sign in to comment.