Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report LSP loading telemetry #75402

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Report LSP loading telemetry #75402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1972097
Allow more specific LSP services to override Any LSP services
dibarbet Oct 4, 2024
23bd767
Add LSP funnel telemetry to help indicate when drop offs occur
dibarbet Oct 4, 2024
cbcfb4a
Cleanup
dibarbet Oct 8, 2024
47eac67
Add counter telemetry log aggregator and cleanup implemention to ensure
dibarbet Oct 10, 2024
0d5ec53
Add test to ensure services apply to the correct server kind
dibarbet Oct 14, 2024
6bd644e
Update comments
dibarbet Oct 14, 2024
e53963b
Remove unnecessary properties on event
dibarbet Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@dibarbet
dibarbet committed Oct 8, 2024
commit cbcfb4a70020603f2ca5e59a4295fe7eafa07b06
6 changes: 1 addition & 5 deletions ...ageServer/Microsoft.CodeAnalysis.LanguageServer/Telemetry/VSCodeRequestTelemetryLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ internal class VSCodeRequestTelemetryLogger() : RequestTelemetryLogger(WellKnown
/// 2. After initial load, almost all requests should resolve to the host workspace.
/// A large amount of misc files requests in 2 could indicate either a bug or feature improvements in order to load what the user is expecting.
/// </summary>
private readonly ConcurrentDictionary<bool, CountLogAggregator<string>> _findDocumentCounters = new()
{
[true] = new(),
[false] = new(),
};
private readonly ConcurrentDictionary<bool, CountLogAggregator<string>> _findDocumentCounters = new();

public static void ReportProjectInitializationComplete()
{
Expand Down
24 changes: 0 additions & 24 deletions ...er/Microsoft.CodeAnalysis.LanguageServer/Telemetry/VSCodeRequestTelemetryLoggerFactory.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/LanguageServer/Protocol/Handler/Telemetry/RequestTelemetryLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ protected virtual void ReportFindDocumentCounter()
}
}));
}
_findDocumentResults.Clear();
}

private void OnFlushed(object? sender, EventArgs e)
Expand Down Expand Up @@ -155,7 +156,6 @@ private void OnFlushed(object? sender, EventArgs e)
}

_requestCounters.Clear();
_findDocumentResults.Clear();
_usedForkedSolutionCounter.Clear();
}

Expand Down
Loading