Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten the namedpipe used to connect with C# extension #70492

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Shorten the namedpipe used to connect with C# extension #70492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update pipe name
  • Loading branch information
@beccamc
beccamc committed Oct 20, 2023
commit bc736bb986495c3fc36670ca1e0024026cf9af5c
5 changes: 4 additions & 1 deletion src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,10 @@ static CliRootCommand CreateCommandLineParser()
const string WINDOWS_NODJS_PREFIX = @"\\.\pipe\";
const string WINDOWS_DOTNET_PREFIX = @"\\.\";

var pipeName = Guid.NewGuid().ToString();
// The pipe name constructed by some systems is very long (due to temp path).
// Shorten the unique id for the pipe.
var newGuid = Guid.NewGuid().ToString();
var pipeName = newGuid.Split('-')[0];

return RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? (WINDOWS_NODJS_PREFIX + pipeName, WINDOWS_DOTNET_PREFIX + pipeName)
Expand Down