Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share common code involved into building dictionaries of members for namespace symbols #67933

Merged
merged 8 commits into from
Apr 26, 2023
Merged

Share common code involved into building dictionaries of members for namespace symbols #67933

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
64c5cda
Get rid of NameToSymbolMapBuilder structure, extract and reuse Immut…
AlekseyTs Apr 23, 2023
32823f9
AddToMultiValueDictionaryBuilder - extract common code out of `if``
AlekseyTs Apr 23, 2023
67186f4
Switch from kind to type check in GetTypesFromMemberMap and CreateNam…
AlekseyTs Apr 23, 2023
b743314
Convert GetTypesFromMemberMap and CreateNameToMembersMap to fully gen…
AlekseyTs Apr 23, 2023
ae5eb60
Move CreateNameToMembersMap and GetTypesFromMemberMap to ImmutableArr…
AlekseyTs Apr 23, 2023
6e8d6bb
Inline/move helpers
AlekseyTs Apr 23, 2023
77b4431
Inline StaticCast.From helper.
AlekseyTs Apr 23, 2023
e437baf
PR feedback
AlekseyTs Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AddToMultiValueDictionaryBuilder - extract common code out of if`
  • Loading branch information
@AlekseyTs
AlekseyTs committed Apr 23, 2023
commit 32823f93baa3582b6c9dc7c35b4957fe482c59b9
4 changes: 2 additions & 2 deletions src/Compilers/Core/Portable/Collections/ImmutableArrayExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,16 +887,16 @@ internal static void AddToMultiValueDictionaryBuilder<K, T>(Dictionary<K, object
if (existingValueOrArray is ArrayBuilder<T> arrayBuilder)
{
// Already a builder in the accumulator, just add to that.
arrayBuilder.Add(item);
}
else
{
// Just a single value in the accumulator so far. Convert to using a builder.
arrayBuilder = ArrayBuilder<T>.GetInstance(capacity: 2);
arrayBuilder.Add((T)existingValueOrArray);
arrayBuilder.Add(item);
accumulator[key] = arrayBuilder;
}

arrayBuilder.Add(item);
}
else
{
Expand Down