Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interceptors: handle duplicates, additional signature validation, etc. #67786

Merged
merged 34 commits into from
Apr 25, 2023
Merged

Interceptors: handle duplicates, additional signature validation, etc. #67786

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5c4e289
Detect duplicate interceptions
RikkiGibson Apr 13, 2023
b769c0e
fix formatting
RikkiGibson Apr 13, 2023
a1f0eab
Fix dictionary usage. Test some file local attribute cases. Check sco…
RikkiGibson Apr 15, 2023
042d1d6
Fix nullable warning
RikkiGibson Apr 17, 2023
565c39a
Test 'params'. Test 'object.ReferenceEquals'. Handle more prototype c…
RikkiGibson Apr 17, 2023
f09ecb9
fix position diagnostics
RikkiGibson Apr 17, 2023
5edf9cf
fix lsp test
RikkiGibson Apr 18, 2023
b5fb444
Don't propagate InvokedAsExtensionMethod past lowering
RikkiGibson Apr 18, 2023
732dd91
Test file path case difference
RikkiGibson Apr 18, 2023
e47ce9d
Permit safe nullable differences
RikkiGibson Apr 19, 2023
678c4aa
Fix DiagnosticTest
RikkiGibson Apr 19, 2023
330ae61
Update spec
RikkiGibson Apr 19, 2023
aec866a
fix example type
RikkiGibson Apr 19, 2023
4b7fa44
Use explicit 'bool' type
RikkiGibson Apr 19, 2023
3534505
remove TODO
RikkiGibson Apr 19, 2023
d2053de
Fix crash when ROSLYN_TEST_USEDASSEMBLIES is defined
RikkiGibson Apr 19, 2023
d47412a
Fix nullable warning
RikkiGibson Apr 19, 2023
ca4cea8
Fix formatting
RikkiGibson Apr 19, 2023
21c1d56
More tests
RikkiGibson Apr 19, 2023
805fc9a
Add more tests
RikkiGibson Apr 20, 2023
87bcad6
Update baselines. Prefer reporting mismatch issues on attribute inste…
RikkiGibson Apr 20, 2023
3da2bad
Handle concurrent attribute decoding
RikkiGibson Apr 20, 2023
f4f05aa
add PROTOTYPE
RikkiGibson Apr 20, 2023
202914a
permit safe scoped variance
RikkiGibson Apr 20, 2023
c677ca7
Execute more test. Test intercepting ReferenceEquals.
RikkiGibson Apr 20, 2023
3a95687
Adjust comment
RikkiGibson Apr 20, 2023
2bfe8e2
adjust comment
RikkiGibson Apr 20, 2023
03be70a
skip verification in InterceptorExtern
RikkiGibson Apr 20, 2023
5c97905
add another duplicate test
RikkiGibson Apr 21, 2023
b6eb568
Clarify comment
RikkiGibson Apr 21, 2023
76d66d9
Add use site info
RikkiGibson Apr 21, 2023
f3c877e
fix double negative
RikkiGibson Apr 21, 2023
43205e8
test interceptable call with method type arguments in signature
RikkiGibson Apr 21, 2023
8664dad
add PROTOTYPE based on offline discussion
RikkiGibson Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use explicit 'bool' type
  • Loading branch information
@RikkiGibson
RikkiGibson committed Apr 19, 2023
commit 4b7fa44eda5c3e4be921d50da520b8f514aad546
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Compilation/CSharpCompilation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3389,7 +3389,7 @@ private bool CheckDuplicateInterceptions(DiagnosticBag diagnostics)
return false;
}

var anyDuplicates = false;
bool anyDuplicates = false;
foreach ((_, OneOrMany<(Location, MethodSymbol)> interceptionsOfAGivenLocation) in _interceptions)
{
Debug.Assert(interceptionsOfAGivenLocation.Count != 0);
Expand Down