Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work to unify threading concepts between Workspace and ProjectSystemProjectFactory (part2) #67524

Merged
merged 5 commits into from
May 2, 2023
Merged

Work to unify threading concepts between Workspace and ProjectSystemProjectFactory (part2) #67524

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
badc524
Use helper
CyrusNajmabadi Mar 28, 2023
acb0d80
Simplify
CyrusNajmabadi Mar 28, 2023
d7e00ea
Remove unused function
CyrusNajmabadi Mar 28, 2023
78850b5
Merge branch 'main' into sharedLock3
CyrusNajmabadi Apr 26, 2023
ef26289
Formatting
CyrusNajmabadi Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify
  • Loading branch information
@CyrusNajmabadi
CyrusNajmabadi committed Mar 28, 2023
commit acb0d807346bfd2c7024c37e0d2ad90ce3a340f6
14 changes: 7 additions & 7 deletions src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProjectFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ public async Task<ProjectSystemProject> CreateAndAddToWorkspaceAsync(string proj
projectId,
displayName: projectSystemName,
language,
assemblyName: assemblyName,
compilationOptions: creationInfo.CompilationOptions,
filePath: creationInfo.FilePath,
parseOptions: creationInfo.ParseOptions);
assemblyName,
creationInfo.CompilationOptions,
creationInfo.FilePath,
creationInfo.ParseOptions);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removed named options i thought were redundant.


var versionStamp = creationInfo.FilePath != null
? VersionStamp.Create(File.GetLastWriteTimeUtc(creationInfo.FilePath))
Expand All @@ -101,10 +101,10 @@ public async Task<ProjectSystemProject> CreateAndAddToWorkspaceAsync(string proj
projectId,
versionStamp,
name: projectSystemName,
assemblyName: assemblyName,
language: language,
checksumAlgorithm: SourceHashAlgorithms.Default, // will be updated when command line is set
assemblyName,
language,
compilationOutputFilePaths: default, // will be updated when command line is set
SourceHashAlgorithms.Default, // will be updated when command line is set
filePath: creationInfo.FilePath,
telemetryId: creationInfo.TelemetryId),
compilationOptions: creationInfo.CompilationOptions,
Expand Down