Work to unify threading concepts between Workspace and ProjectSystemProjectFactory (part2) #67524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 28, 2023
| { | ||
| w.OnProjectAdded(projectInfo); | ||
| } | ||
| await w.SetCurrentSolutionAsync( |
There was a problem hiding this comment.
this now uses the new helper, spinning until it 'wins' and actually makes the change to the workspace. this is the primary functional change intended by thsi PR, moving away from manually splatting the OnSolutionAdded call.
|
@jasonmalinowski ptal. fairly simple change. |
CyrusNajmabadi
commented
May 2, 2023
| @@ -78,57 +77,76 @@ public ProjectSystemProjectFactory(Workspace workspace, IFileChangeWatcher fileC | |||
|
|
|||
| public async Task<ProjectSystemProject> CreateAndAddToWorkspaceAsync(string projectSystemName, string language, ProjectSystemProjectCreationInfo creationInfo, ProjectSystemHostInfo hostInfo) | |||
| { | |||
| var id = ProjectId.CreateNewId(projectSystemName); | |||
| var projectId = ProjectId.CreateNewId(projectSystemName); | |||
There was a problem hiding this comment.
just a rename as 'id' was very confusing to me.
CyrusNajmabadi
commented
May 2, 2023
| assemblyName, | ||
| creationInfo.CompilationOptions, | ||
| creationInfo.FilePath, | ||
| creationInfo.ParseOptions); |
There was a problem hiding this comment.
just removed named options i thought were redundant.
CyrusNajmabadi
commented
May 2, 2023
| compilationOptions: creationInfo.CompilationOptions, | ||
| filePath: creationInfo.FilePath, | ||
| parseOptions: creationInfo.ParseOptions); |
There was a problem hiding this comment.
pulled creation of this info singleton up out of hte lambda.
|
@dibarbet ptal as jason is away currently. thanks! |
dibarbet
approved these changes
May 2, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #67522
Continue to move existing ProjectSystemProjectFactory code over to using transformation-helper supplied by workspace.