Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roslyn bits #8764

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Update Roslyn bits #8764

merged 3 commits into from
Jun 1, 2023

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented May 25, 2023 •
edited
Loading

Summary of the changes

Fixes #8652

/cc @jjonescz

@maryamariyan maryamariyan requested review from a team as code owners May 25, 2023 19:17
@maryamariyan maryamariyan requested review from NikolaMilosavljevic and removed request for a team May 25, 2023 19:17
@maryamariyan maryamariyan mentioned this pull request May 25, 2023
Closed
NikolaMilosavljevic
NikolaMilosavljevic approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only glanced over files in eng folder. If darc tooling was used to make these changes, they should be complete and ok.

I suggest a review by someone in razor for all other changes.

@333fred
Copy link
Member

333fred commented May 25, 2023

Thanks Maryam, #8762 is blocked on this change. Will take a look now.

333fred
333fred previously approved these changes May 25, 2023
View reviewed changes
@333fred 333fred dismissed their stale review May 25, 2023 20:51

Actually, test failures look real

@davidwengier
Copy link
Contributor

Test failures do look real. Looks like we're compiling against the netstandard2.0 library, but running tests against net7.0. Might need a Roslyn change to have the two not be binarily different (is that a word?)

@333fred
Copy link
Member

333fred commented May 30, 2023

@maryamariyan any progress on this?

@maryamariyan maryamariyan merged commit be8988b into main Jun 1, 2023
@maryamariyan maryamariyan deleted the update-packages branch June 1, 2023 20:23
@maryamariyan maryamariyan mentioned this pull request Jun 1, 2023
Closed
@allisonchou allisonchou mentioned this pull request Jun 7, 2023
Closed
@maryamariyan maryamariyan self-assigned this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier left review comments

@DustinCampbell DustinCampbell DustinCampbell left review comments

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@maryamariyan maryamariyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrading roslyn bits causing version downgrades, needs further investigation
5 participants
@maryamariyan @333fred @davidwengier @DustinCampbell @NikolaMilosavljevic