Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for OnAppearing of Page called again, although this page was on already replaced NavigationStack #25596

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+157 −7
Open

Fix for OnAppearing of Page called again, although this page was on already replaced NavigationStack #25596

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
323d21d
fix-25089-Updated `SendAppearing` method to call `PresentedPageAppear…
BagavathiPerumal Oct 30, 2024
a568b57
fix-25089-Testcase added.
BagavathiPerumal Nov 4, 2024
5676af5
fix-25089-Removed the `#if !MACCATALYST` condition to ensure the test…
BagavathiPerumal Nov 4, 2024
36aed7c
fix-25089-Renamed the class to avoid the conflict.
BagavathiPerumal Nov 4, 2024
98d2eca
fix-25089-Resolved NullReferenceException in testcase by implementing…
BagavathiPerumal Nov 7, 2024
650c85c
fix-25089-Updated UnitTestcase and removed UI testcase.
BagavathiPerumal Jan 16, 2025
24568eb
fix-25089-Optimized the Unit Testcase.
BagavathiPerumal Jan 16, 2025
83ca33f
- fix testshell so it creates templated content and add additional test
PureWeen Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix-25089-Updated SendAppearing method to call `PresentedPageAppear… 
…ing` only if the page is visible.
  • Loading branch information
@BagavathiPerumal @PureWeen
BagavathiPerumal authored and PureWeen committed Jan 16, 2025
commit 323d21de39e1d8350efd3592963f0e11bc8647f8
14 changes: 13 additions & 1 deletion src/Controls/src/Core/Shell/ShellSection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,22 @@ internal override void SendDisappearing()
PresentedPageDisappearing();
}

bool IsPageVisible()
{
if (this is IShellSectionController sectionController && sectionController.PresentedPage is not null)
{
return sectionController.PresentedPage == ((IShellContentController)CurrentItem)?.Page;
}
return false;
}

internal override void SendAppearing()
{
base.SendAppearing();
PresentedPageAppearing();
if (IsPageVisible())
{
PresentedPageAppearing();
}
}

class NavigationImpl : NavigationProxy
Expand Down