/azp run

/azp run

/rebase

/azp run

Can you use a unit test instead of a UITest for this one?

@PureWeen, we couldn't recreate the same UI test scenario in the unit test case because the Shell.Current is always null when try to navigate to another page by using Shell.Current.GoToAsync().

    [Fact]
    public async Task AppearingFireOnMultipleModals()
    {
        var windowPage = new ContentPage();
        var modalPage1 = new ContentPage();
        var modalPage2 = new ContentPage();

        TestShell newShell = new TestShell
        {
            FlyoutBehavior = FlyoutBehavior.Disabled
        };

        Routing.RegisterRoute("modalPage1", typeof(ContentPage));
        Routing.RegisterRoute("modalPage2", typeof(ContentPage));

        ShellContent homeShellContent = new ShellContent
        {
            FlyoutItemIsVisible = false,
            Route = "windowPage",
            ContentTemplate = new DataTemplate(()=> windowPage)
        };

        newShell.Items.Add(homeShellContent);
        TabBar tabBar = new TabBar();
        Tab testTab = new Tab
        {
            Title = "TestTab"
        };
        
        ShellContent parameterShellContent = new ShellContent
        {
            Route = "modalPage2",
            ContentTemplate = new DataTemplate(()=> modalPage2)
        };

        testTab.Items.Add(parameterShellContent);
        tabBar.Items.Add(testTab);
        newShell.Items.Add(tabBar);

        int modal1Appearing = 0;
        int modal2Appearing = 0;
        int windowAppearing = 0;
        int windowDisappearing = 0;

        modalPage1.Appearing += (_, _) => modal1Appearing++;
        modalPage2.Appearing += (_, _) => modal2Appearing++;
        windowPage.Appearing += (_, _) => windowAppearing++;
        
        var window = new Window(new Shell() { CurrentItem = windowPage });

        await Shell.Current.GoToAsync("modalPage1", true);
        await Shell.Current.GoToAsync("//modalPage2", true);
        await Shell.Current.GoToAsync("//windowPage", true);

        Assert.Equal(1, modal1Appearing);
        Assert.Equal(2, windowAppearing);

    }

Use the shell instance you instantiated vs Shell.Current

await newShell.GoToAsync("modalPage1", true);
			await newShell.GoToAsync("//modalPage2", true);
			await newShell.GoToAsync("//windowPage", true);

@PureWeen, We are unable to recreate the same UI test scenario in the unit test case because the Appearing event is not triggered when navigating from one ShellContent page to another. As a result, we cannot maintain the appearing count in the test case.

[Fact]
public async Task AppearingFireOnMultipleModal()
{
    var windowPage = new MainPage();
    var modalPage1 = new FirstPage();
    TestShell newShell = new TestShell
    {
        FlyoutBehavior = FlyoutBehavior.Disabled
    };
 
    Routing.RegisterRoute("windowPage", typeof(MainPage));
    Routing.RegisterRoute("modalPage1", typeof(FirstPage));
 
    ShellContent shellContent1 = new ShellContent
    {
        FlyoutItemIsVisible = false,
        Route = "windowPage",
        ContentTemplate = new DataTemplate(() => windowPage)
    };
    ShellContent shellContent2 = new ShellContent
    {
        FlyoutItemIsVisible = false,
        Route = "modalPage1",
        ContentTemplate = new DataTemplate(() => modalPage1)
    };
 
    newShell.Items.Add(shellContent1);
    newShell.Items.Add(shellContent2);
 
    modalPage1.Appearing += ModalPage1Appearing;
    windowPage.Appearing += ModalPage2Appearing;
 
    await newShell.GoToAsync("modalPage1", true);
    await newShell.GoToAsync("//windowPage", true);
}
 
private void ModalPage1Appearing(object sender, EventArgs e)
{
}
 
private void ModalPage2Appearing(object sender, EventArgs e)
{
}

Use the shell instance you instantiated vs Shell.Current

await newShell.GoToAsync("modalPage1", true);
			await newShell.GoToAsync("//modalPage2", true);
			await newShell.GoToAsync("//windowPage", true);

@PureWeen, We are unable to recreate the same UI test scenario in the unit test case because the Appearing event is not triggered when navigating from one ShellContent page to another. As a result, we cannot maintain the appearing count in the test case.

[Fact]
public async Task AppearingFireOnMultipleModal()
{
    var windowPage = new MainPage();
    var modalPage1 = new FirstPage();
    TestShell newShell = new TestShell
    {
        FlyoutBehavior = FlyoutBehavior.Disabled
    };
 
    Routing.RegisterRoute("windowPage", typeof(MainPage));
    Routing.RegisterRoute("modalPage1", typeof(FirstPage));
 
    ShellContent shellContent1 = new ShellContent
    {
        FlyoutItemIsVisible = false,
        Route = "windowPage",
        ContentTemplate = new DataTemplate(() => windowPage)
    };
    ShellContent shellContent2 = new ShellContent
    {
        FlyoutItemIsVisible = false,
        Route = "modalPage1",
        ContentTemplate = new DataTemplate(() => modalPage1)
    };
 
    newShell.Items.Add(shellContent1);
    newShell.Items.Add(shellContent2);
 
    modalPage1.Appearing += ModalPage1Appearing;
    windowPage.Appearing += ModalPage2Appearing;
 
    await newShell.GoToAsync("modalPage1", true);
    await newShell.GoToAsync("//windowPage", true);
}
 
private void ModalPage1Appearing(object sender, EventArgs e)
{
}
 
private void ModalPage2Appearing(object sender, EventArgs e)
{
}

The sample code you have here isn't quite correct.

Having a Route named "modalPage1" and a shell content named "modalPage1" isn't going to operate correctly.

if you look at ShellLifeCycleTests you'll see there are a number of scenarios where we've wired into appearing and it works alright

Use the shell instance you instantiated vs Shell.Current

await newShell.GoToAsync("modalPage1", true);
			await newShell.GoToAsync("//modalPage2", true);
			await newShell.GoToAsync("//windowPage", true);

@PureWeen, We are unable to recreate the same UI test scenario in the unit test case because the Appearing event is not triggered when navigating from one ShellContent page to another. As a result, we cannot maintain the appearing count in the test case.

[Fact]
public async Task AppearingFireOnMultipleModal()
{
    var windowPage = new MainPage();
    var modalPage1 = new FirstPage();
    TestShell newShell = new TestShell
    {
        FlyoutBehavior = FlyoutBehavior.Disabled
    };
 
    Routing.RegisterRoute("windowPage", typeof(MainPage));
    Routing.RegisterRoute("modalPage1", typeof(FirstPage));
 
    ShellContent shellContent1 = new ShellContent
    {
        FlyoutItemIsVisible = false,
        Route = "windowPage",
        ContentTemplate = new DataTemplate(() => windowPage)
    };
    ShellContent shellContent2 = new ShellContent
    {
        FlyoutItemIsVisible = false,
        Route = "modalPage1",
        ContentTemplate = new DataTemplate(() => modalPage1)
    };
 
    newShell.Items.Add(shellContent1);
    newShell.Items.Add(shellContent2);
 
    modalPage1.Appearing += ModalPage1Appearing;
    windowPage.Appearing += ModalPage2Appearing;
 
    await newShell.GoToAsync("modalPage1", true);
    await newShell.GoToAsync("//windowPage", true);
}
 
private void ModalPage1Appearing(object sender, EventArgs e)
{
}
 
private void ModalPage2Appearing(object sender, EventArgs e)
{
}

The sample code you have here isn't quite correct.

Having a Route named "modalPage1" and a shell content named "modalPage1" isn't going to operate correctly.

if you look at ShellLifeCycleTests you'll see there are a number of scenarios where we've wired into appearing and it works alright

@PureWeen, I have added the unit test case based on your suggestion for the scenario. Could you please share any further suggestions.