[net9] Try fix running UITests on iOS18 (#25070)

* [housekeeping] Update & Consolidate Appium + driver versions (#24817) * Update appium + driver versions Updating to latest * Move appium versions to eng/Versions.props * Fix ps1 get-location * Check if appium is completely missing too No need to attempt to uninstall appium if it's not installed * - bump versions * - fix script --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Try iOS18 device * See if this works * Try xs --------- Co-authored-by: Jonathan Dick <jodick@microsoft.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
dotnet · rmarinho · Oct 17, 2024 · Oct 16, 2024 · Oct 16, 2024 · Oct 2, 2024
commit 31e5930cddb392df4e50f5f9327cb337a3f718ef
@@ -146,6 +146,14 @@
     <NSubstitutePackageVersion>5.1.0</NSubstitutePackageVersion>
     <CoverletCollectorPackageVersion>6.0.0</CoverletCollectorPackageVersion>
   </PropertyGroup>
+  <PropertyGroup>
+    <!-- Appium -->
+    <AppiumVersion>2.11.5</AppiumVersion>
+    <AppiumWindowsDriverVersion>2.12.32</AppiumWindowsDriverVersion>
+    <AppiumXCUITestDriverVersion>7.27.0</AppiumXCUITestDriverVersion>
+    <AppiumMac2DriverVersion>1.19.1</AppiumMac2DriverVersion>
+    <AppiumUIAutomator2DriverVersion>3.8.0</AppiumUIAutomator2DriverVersion>
+  </PropertyGroup>
   <PropertyGroup>
     <!-- arcade -->
     <!-- xunit -->

@@ -1,7 +1,7 @@
 #addin nuget:?package=Cake.AppleSimulator&version=0.2.0
 #load "./uitests-shared.cake"
 
-const string DefaultVersion = "17.2";
+const string DefaultVersion = "18.0";
 const string DefaultTestDevice = $"ios-simulator-64_{DefaultVersion}";
 
 // Required arguments

@@ -40,14 +40,54 @@ Find the script for that on the DevDiv Azure DevOps instance, Engineering team,
 
 param
 (
-    [string] $appiumVersion = '2.11.0',
-    [string] $windowsDriverVersion = '2.12.23',
-    [string] $androidDriverVersion = '3.7.0',    
-    [string] $iOSDriverVersion = '7.21.0',
-    [string] $macDriverVersion = '1.17.4',
+    [string] $appiumVersion = '',
+    [string] $windowsDriverVersion = '',
+    [string] $androidDriverVersion = '',
+    [string] $iOSDriverVersion = '',
+    [string] $macDriverVersion = '',
     [string] $logsDir = '../appium-logs'
 )
 
+# By default, versions should be read from /eng/Versions.props
+$getLocation = $PSScriptRoot
+$versionPropsPath = [IO.Path]::Combine($getLocation, '..', 'Versions.props')
+
+Write-Output "Checking $versionPropsPath for versions..."
+
+if (Test-Path $versionPropsPath)
+{
+    Write-Output "Reading versions from Version.props..."
+    [xml]$versionProps = Get-Content $versionPropsPath
+
+    $versionPropsAppiumVersion = $versionProps.Project.PropertyGroup.AppiumVersion | Where-Object { $_ -ne $null } | Select-Object -Last 1
+    if ($versionPropsAppiumVersion -ne $null) {
+        $appiumVersion = $versionPropsAppiumVersion
+    }
+
+    $versionPropsWindowsDriverVersion = $versionProps.Project.PropertyGroup.AppiumWindowsDriverVersion | Where-Object { $_ -ne $null } | Select-Object -Last 1
+    if ($versionPropsWindowsDriverVersion -ne $null) {
+        $windowsDriverVersion = $versionPropsWindowsDriverVersion
+    }
+
+    $versionPropsUIAutomator2DriverVersion = $versionProps.Project.PropertyGroup.AppiumUIAutomator2DriverVersion | Where-Object { $_ -ne $null } | Select-Object -Last 1
+    if ($versionPropsUIAutomator2DriverVersion -ne $null) {
+        $androidDriverVersion = $versionPropsUIAutomator2DriverVersion
+    }
+
+    $versionPropsXCUItestDriverVersion = $versionProps.Project.PropertyGroup.AppiumXCUITestDriverVersion | Where-Object { $_ -ne $null } | Select-Object -Last 1
+    if ($versionPropsXCUItestDriverVersion -ne $null) {
+        $iOSDriverVersion = $versionPropsXCUItestDriverVersion
+    }
+
+    $versionPropsMac2DriverVersion = $versionProps.Project.PropertyGroup.AppiumMac2DriverVersion | Where-Object { $_ -ne $null } | Select-Object -Last 1
+    if ($versionPropsMac2DriverVersion -ne $null) {
+        $macDriverVersion = $versionPropsMac2DriverVersion
+    }
+}
+else {
+    throw "The version.props file was not found at path: $versionPropsPath"
+}
+
 Write-Output  "Welcome to the Appium installer"
 
 Write-Output  "Node version"
@@ -87,11 +127,16 @@ if ($appiumCurrentVersion) {
     Write-Output  "No Appium version installed"
 }
 
+# Check if we found a version of appium at all
+$missingAppium = [string]::IsNullOrEmpty($appiumCurrentVersion)
+
 # If current version does not match the one we want, uninstall and install the new version
-if ($appiumCurrentVersion -ne $appiumVersion) {
-    Write-Output  "Uninstalling appium $appiumCurrentVersion"
-    npm uninstall --logs-dir=$logsDir --loglevel $npmLogLevel -g appium
-    Write-Output  "Uninstalled appium $appiumCurrentVersion"
+if ($missingAppium -or ($appiumCurrentVersion -ne $appiumVersion)) {
+    if (-not $missingAppium) {
+        Write-Output  "Uninstalling appium $appiumCurrentVersion"
+        npm uninstall --logs-dir=$logsDir --loglevel $npmLogLevel -g appium
+        Write-Output  "Uninstalled appium $appiumCurrentVersion"
+    }
 
     Write-Output  "Installing appium $appiumVersion"
     npm install --logs-dir=$logsDir --loglevel $npmLogLevel -g appium@$appiumVersion

@@ -63,7 +63,7 @@ public override IConfig GetTestConfig()
 					break;
 				case TestDevice.iOS:
 					config.SetProperty("DeviceName", Environment.GetEnvironmentVariable("DEVICE_NAME") ?? "iPhone Xs");
-					config.SetProperty("PlatformVersion", Environment.GetEnvironmentVariable("PLATFORM_VERSION") ?? "17.2");
+					config.SetProperty("PlatformVersion", Environment.GetEnvironmentVariable("PLATFORM_VERSION") ?? "18.0");
 					config.SetProperty("Udid", Environment.GetEnvironmentVariable("DEVICE_UDID") ?? "");
 					break;
 				case TestDevice.Windows:
@@ -142,7 +142,11 @@ but both can happen.
 						var platformVersion = (string)((AppiumApp)App).Driver.Capabilities.GetCapability("platformVersion");
 						var device = (string)((AppiumApp)App).Driver.Capabilities.GetCapability("deviceName");
 
-						if (deviceName == "iPhone Xs (iOS 17.2)" || (device.Contains(" Xs", StringComparison.OrdinalIgnoreCase) && platformVersion == "17.2"))
+						if (device.Contains(" Xs", StringComparison.OrdinalIgnoreCase) && platformVersion == "18.0")
+						{
+							environmentName = "ios";
+						}
+						else if (deviceName == "iPhone Xs (iOS 17.2)" || (device.Contains(" Xs", StringComparison.OrdinalIgnoreCase) && platformVersion == "17.2"))
 						{
 							environmentName = "ios";
 						}