Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unable to select a tab after backing out of a page and returning. #25011

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Fix for unable to select a tab after backing out of a page and returning. #25011

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e8774bf
fix-24741-Reset the selected property for all item and mapped the IsS…
BagavathiPerumal Sep 18, 2024
c86d458
fix-24741-Removed the code that reset the MenuItemSource and added Pr…
BagavathiPerumal Sep 19, 2024
89016af
fix-24741-Optimized the fix by making SelectedItem null in DisConnect…
BagavathiPerumal Oct 3, 2024
8b8886d
fix-24741-Optimized the fix.
BagavathiPerumal Oct 3, 2024
a0a366c
Added UITest
jsuarezruiz Oct 17, 2024
30cca7c
fix-24741-Resolved the TitleColor not updating issue.
BagavathiPerumal Oct 28, 2024
bd85bc2
Fixed UITest
jsuarezruiz Nov 4, 2024
d5f052e
fix-24741-Testcase changes updated.
BagavathiPerumal Nov 5, 2024
7fc9118
fix-24741-Added testcase screenshot.
BagavathiPerumal Nov 5, 2024
dfc1643
fix-24741-Updated testcase screenshot.
BagavathiPerumal Nov 7, 2024
efeab16
Merge branch 'main' into fix-24741
jsuarezruiz Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix-24741-Optimized the fix by making SelectedItem null in DisConnect… 
…Handler.
  • Loading branch information
@BagavathiPerumal @jsuarezruiz
BagavathiPerumal authored and jsuarezruiz committed Nov 8, 2024
commit 89016af631e91da9997261f1648c11f8a2962b52
11 changes: 3 additions & 8 deletions src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,6 @@ void OnHandlerDisconnected(FrameworkElement? platformView)
{
_navigationView.OnApplyTemplateFinished -= OnApplyTemplateFinished;
_navigationView.SizeChanged -= OnNavigationViewSizeChanged;

if (_navigationView.MenuItemsSource is ObservableCollection<NavigationViewItemViewModel> items)
{
foreach (var item in items)
{
item.IsSelected = false;
}
}
}

if (platformView is WFrame wFrame)
Expand All @@ -142,7 +134,10 @@ void OnHandlerDisconnected(FrameworkElement? platformView)
Appearing -= OnTabbedPageAppearing;
Disappearing -= OnTabbedPageDisappearing;
if (_navigationView != null)
{
_navigationView.SelectedItem = null;
_navigationView.SelectionChanged -= OnSelectedMenuItemChanged;
}

OnTabbedPageDisappearing(this, EventArgs.Empty);

Expand Down