Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java.Base] Flush Java.Base-ref.cs #1290

Closed
wants to merge 1 commit into from

Conversation

jonpryor
Copy link
Member

@jonpryor jonpryor commented Jan 9, 2025

Context: #1288

We're considering adding a check to CI if the build changes any files, and src/Java.Base-ref.cs is one of the primary instigators for such in-tree changes.

Flush the current output of Java.Base-ref.cs when building against JDK-11, which is the current JDK used on dotnet/java-interop CI.

Context: #1288

We're considering adding a check to CI if the build changes any files,
and `src/Java.Base-ref.cs` is one of the primary instigators for such
in-tree changes.

Flush the current output of `Java.Base-ref.cs` when building against
JDK-11, which is the current JDK used on dotnet/java-interop CI.
@jonpryor
Copy link
Member Author

jonpryor commented Jan 9, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonpryor
Copy link
Member Author

jonpryor commented Jan 9, 2025

Superseded by PR #1291. Apparently, Java.Base-ref.cs was already built against JDK-17, so preferring JDK-17 means the file contents won't change! (Except maybe line endings?)

@jonpryor jonpryor closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant