Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Combining the T[] and OwnedBuffer<T> fields of Buffer<T> into a single object #1634

Merged
merged 11 commits into from
Jun 28, 2017
Merged

Combining the T[] and OwnedBuffer<T> fields of Buffer<T> into a single object #1634

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
89b3f45
Changing Buffer<T> fields to void* and object
ahsonkhan Jun 20, 2017
16182d4
Fixing Buffer Span and Retain to account for object being null
ahsonkhan Jun 22, 2017
97e7263
WIP - fixing impl of retain
ahsonkhan Jun 22, 2017
b70cf9a
Using last bit of index to differentiate between array & ownedbuffer
ahsonkhan Jun 27, 2017
690c089
Merge branch 'master' of https://github.com/dotnet/corefxlab into Buf…
ahsonkhan Jun 27, 2017
a29cfa8
Fixing use of index by using bitmask to ignore first bit
ahsonkhan Jun 27, 2017
26b8bc6
Removing unnecessary unsafe keyword since buffer no longer contains v…
ahsonkhan Jun 27, 2017
5261df6
Adding owned buffer test, use after gc collection
ahsonkhan Jun 27, 2017
b1af4fe
Aggressive inlining span property
ahsonkhan Jun 27, 2017
3a794e4
Addressing PR comment
ahsonkhan Jun 27, 2017
c379c93
Tweaking test and comment
ahsonkhan Jun 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing unnecessary unsafe keyword since buffer no longer contains v… 
…oid*
  • Loading branch information
@ahsonkhan
ahsonkhan committed Jun 27, 2017
commit 26b8bc6b1095da17c953774218e5d4c418327fb3
2 changes: 1 addition & 1 deletion src/System.Buffers.Primitives/System/Buffers/Buffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace System
{
[DebuggerTypeProxy(typeof(BufferDebuggerView<>))]
public unsafe struct Buffer<T>
public struct Buffer<T>
{
readonly object _arrayOrOwnedBuffer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a comment that explains how this works, i.e. that _index high order bit is used to identify the modes.

readonly int _index;
Expand Down
2 changes: 1 addition & 1 deletion src/System.Buffers.Primitives/System/Buffers/ReadOnlyBuffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace System
{
[DebuggerTypeProxy(typeof(ReadOnlyBufferDebuggerView<>))]
public unsafe struct ReadOnlyBuffer<T>
public struct ReadOnlyBuffer<T>
{
readonly object _arrayOrOwnedBuffer;
readonly int _index;
Expand Down