Revert "Add support for user-supplied project file detection" #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1aab1c0.
|
Sounds fine to me. It could also be passed as a parameter in cc @Genbox If you want to take another stab at it taking @adamsitnik's comments into account. |
timcassell
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Reverts #2684
I appreciate the contribution, but the design is overcomplicated. I have done similar things in the past, but have learned from mistakes (the hard way). I believe thaat we should put more effort into introducing new public API and ideally follow rules described in Framework Design Guidelines: Conventions, Idioms, and Patterns for Reusable .Net Libraries book.
It introduced a new interface (with a single method), a class (to represent two arguments) and an enum (with a single value). All of that could have been just a lambda. Example:
Func<BenchmarkCase, ILogger, FileInfo?>. I know that it was done for the sake of extensibility, but it's a niche feature request and we simply don't need that.It introduced the ability to customize a project file path outside of a toolchain, which so far was always responsible for that (via virtual method). At the same time, it introduced a possibility to specify multiple locators with no clear separation of which is used for given toolchain.
I believe that this responsibility should stay within the toolchains. Generators to be exact. And if we want to make it customizable, we should allow for providing the path via command line arguments.
cc @timcassell