Update isHistory to match new interface. (ianstormtaylor#5197)

* Update `isHistory` to match new interface. This change merely preserves the original functionality and does not add verification of Batch's new `selectionBefore` property. * Add changeset.
donaldxdonald · Nov 17, 2022 · 70b64dc · 70b64dc
1 parent e139c11
commit 70b64dc
Show file tree

Hide file tree

Showing 7 changed files with 91 additions and 3 deletions.
diff --git a/.changeset/real-badgers-pull.md b/.changeset/real-badgers-pull.md
@@ -0,0 +1,5 @@
+---
+'slate-history': patch
+---
+
+Fix isHistory check.
diff --git a/packages/slate-history/src/history.ts b/packages/slate-history/src/history.ts
@@ -27,8 +27,10 @@ export const History = {
       isPlainObject(value) &&
       Array.isArray(value.redos) &&
       Array.isArray(value.undos) &&
-      (value.redos.length === 0 || Operation.isOperationList(value.redos[0])) &&
-      (value.undos.length === 0 || Operation.isOperationList(value.undos[0]))
+      (value.redos.length === 0 ||
+        Operation.isOperationList(value.redos[0].operations)) &&
+      (value.undos.length === 0 ||
+        Operation.isOperationList(value.undos[0].operations))
     )
   },
 }
diff --git a/packages/slate-history/test/index.js b/packages/slate-history/test/index.js
@@ -1,7 +1,7 @@
 import assert from 'assert'
 import { fixtures } from '../../../support/fixtures'
 import { createHyperscript } from 'slate-hyperscript'
-import { withHistory } from '..'
+import { History, withHistory } from '..'
 
 describe('slate-history', () => {
   fixtures(__dirname, 'undo', ({ module }) => {
@@ -12,6 +12,14 @@ describe('slate-history', () => {
     assert.deepEqual(editor.children, output.children)
     assert.deepEqual(editor.selection, output.selection)
   })
+
+  fixtures(__dirname, 'isHistory', ({ module }) => {
+    const { input, run, output } = module
+    const editor = withTest(withHistory(input))
+    run(editor)
+    const result = History.isHistory(editor.history)
+    assert.strictEqual(result, output)
+  })
 })
 
 export const jsx = createHyperscript({

diff --git a/packages/slate-history/test/isHistory/after-edit.js b/packages/slate-history/test/isHistory/after-edit.js
@@ -0,0 +1,18 @@
+/** @jsx jsx */
+
+import { Transforms } from 'slate'
+import { jsx } from '..'
+
+export const input = (
+  <editor>
+    <block>
+      Initial text <cursor />
+    </block>
+  </editor>
+)
+
+export const run = editor => {
+  Transforms.insertText(editor, 'additional text')
+}
+
+export const output = true
diff --git a/packages/slate-history/test/isHistory/after-redo.js b/packages/slate-history/test/isHistory/after-redo.js
@@ -0,0 +1,21 @@
+/** @jsx jsx */
+
+import { Transforms } from 'slate'
+import { jsx } from '..'
+
+export const input = (
+  <editor>
+    <block>
+      Initial text <cursor />
+    </block>
+  </editor>
+)
+
+export const run = editor => {
+  Transforms.insertText(editor, 'additional text')
+
+  editor.undo()
+  editor.redo()
+}
+
+export const output = true
diff --git a/packages/slate-history/test/isHistory/after-undo.js b/packages/slate-history/test/isHistory/after-undo.js
@@ -0,0 +1,20 @@
+/** @jsx jsx */
+
+import { Transforms } from 'slate'
+import { jsx } from '..'
+
+export const input = (
+  <editor>
+    <block>
+      Initial text <cursor />
+    </block>
+  </editor>
+)
+
+export const run = editor => {
+  Transforms.insertText(editor, 'additional text')
+
+  editor.undo()
+}
+
+export const output = true
diff --git a/packages/slate-history/test/isHistory/before-edit.js b/packages/slate-history/test/isHistory/before-edit.js
@@ -0,0 +1,14 @@
+/** @jsx jsx */
+import { jsx } from '..'
+
+export const input = (
+  <editor>
+    <block>
+      Initial text <cursor />
+    </block>
+  </editor>
+)
+
+export const run = () => {}
+
+export const output = true