Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partition ranges, covering indexes, smarter iterators #1116

Merged
merged 13 commits into from
Dec 16, 2020
Merged

partition ranges, covering indexes, smarter iterators #1116

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
be2c221
covering indexes
Dec 11, 2020
52108ae
ignore this venv dir that I got from sysbench
Dec 11, 2020
9110c9c
skip some broken query explanation tests. Zach is going to look into…
Dec 11, 2020
38e9b92
merge partition and covering index changes
Dec 12, 2020
7bef098
test new map iterator for indexes
Dec 12, 2020
30b3485
index optimizations and fixes
Dec 15, 2020
628ec20
perf comparison script
Dec 15, 2020
1c77b54
merged master, resolved conflicts
andy-wm-arthur Dec 15, 2020
64f41d9
fix copyright headers, repofmt
andy-wm-arthur Dec 15, 2020
12d95b8
incensitive column name checks
Dec 16, 2020
1170757
pr feedback
Dec 16, 2020
5e7c137
PR feedback
Dec 16, 2020
33111c6
pr feedback
Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip some broken query explanation tests. Zach is going to look into … 
…these in the future
  • Loading branch information
Brian Hendriks committed Dec 11, 2020
commit 9110c9cded227afa248165db3c25e7558b7766c2
21 changes: 21 additions & 0 deletions go/libraries/doltcore/sqle/enginetest/dolt_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package enginetest

import (
"github.com/dolthub/dolt/go/libraries/utils/set"
"testing"

"github.com/dolthub/go-mysql-server/enginetest"
Expand Down Expand Up @@ -60,6 +61,26 @@ func TestVersionedQueries(t *testing.T) {
// Tests of choosing the correct execution plan independent of result correctness. Mostly useful for confirming that
// the right indexes are being used for joining tables.
func TestQueryPlans(t *testing.T) {
// TODO: FIX THESE TESTS!!!
skipped := set.NewStrSet([]string{
"SELECT * FROM mytable mt INNER JOIN othertable ot ON mt.i = ot.i2 AND mt.i > 2",
"SELECT pk,i,f FROM one_pk LEFT JOIN niltable ON pk=i WHERE pk > 1",
"SELECT pk,i,f FROM one_pk LEFT JOIN niltable ON pk=i WHERE pk > 1 ORDER BY 1",
"SELECT pk,pk2 FROM one_pk t1, two_pk t2 WHERE pk=1 AND pk2=1 ORDER BY 1,2",
`SELECT i FROM mytable mt
WHERE (SELECT i FROM mytable where i = mt.i and i > 2) IS NOT NULL
AND (SELECT i2 FROM othertable where i2 = i) IS NOT NULL`,
"SELECT pk,pk2, (SELECT pk from one_pk where pk = 1 limit 1) FROM one_pk t1, two_pk t2 WHERE pk=1 AND pk2=1 ORDER BY 1,2",
})

tests := make([]enginetest.QueryPlanTest, 0, len(enginetest.PlanTests))
for _, currTest := range enginetest.PlanTests {
if !skipped.Contains(currTest.Query) {
tests = append(tests, currTest)
}
}
enginetest.PlanTests = tests

// Parallelism introduces Exchange nodes into the query plans, so disable.
// TODO: exchange nodes should really only be part of the explain plan under certain debug settings
enginetest.TestQueryPlans(t, newDoltHarness(t).WithParallelism(1))
Expand Down