Android: Hook up the new config system #8975
Conversation
JosJuice
force-pushed
the
android-new-config
branch
2 times, most recently
from
c0099b6 to
776ffb6
Compare
JosJuice
force-pushed
the
android-new-config
branch
from
776ffb6 to
5808ab5
Compare
JosJuice
force-pushed
the
android-new-config
branch
from
5808ab5 to
5479bc7
Compare
JosJuice
force-pushed
the
android-new-config
branch
2 times, most recently
from
83dbeb4 to
5595ad7
Compare
...droid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java
Outdated
Show resolved
Hide resolved
JosJuice
force-pushed
the
android-new-config
branch
2 times, most recently
from
ced1b0b to
9228997
Compare
...ain/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/FilePickerViewHolder.java
Outdated
Show resolved
Hide resolved
JosJuice
force-pushed
the
android-new-config
branch
from
9228997 to
8866da0
Compare
JosJuice
force-pushed
the
android-new-config
branch
from
8866da0 to
62a3bf0
Compare
JosJuice
force-pushed
the
android-new-config
branch
2 times, most recently
from
35c0cbb to
024c37f
Compare
JosJuice
force-pushed
the
android-new-config
branch
2 times, most recently
from
d4148d9 to
f2796f2
Compare
JosJuice
force-pushed
the
android-new-config
branch
from
f2796f2 to
734152c
Compare
|
After the conflicts are fixed, feel free to merge this once the buildbot checks pass. This has been sitting around for quite a while (sorry about that!) |
|
I'll probably be able to review this within a day or two. I still need to carefully rebase my Wii Overlay PR. A rebase for this PR would be helpful though. |
JosJuice
force-pushed
the
android-new-config
branch
2 times, most recently
from
832ffe4 to
3dacc00
Compare
|
I'll probably need another two days until I review this, sorry. Game-specific settings in the Wii Overlay PR are giving me trouble after a rebase so I should figure out what's going on there before I look at this PR. |
|
Let's try to get everything with the settings/features setup before the next progress report so we can give Android Users some nice benefits and quality of life features. |
|
Nope, I'm just saying we try to get this all squared away before the end of the month. |
Except controller settings, because those would be annoying to fit into the same system, and I only need the non-controller settings to be brought over for the next commits to work.
JosJuice
force-pushed
the
android-new-config
branch
from
3dacc00 to
5d07c39
Compare
I was hoping we would be able to pull in the default values from C++, but it seems like more trouble than it's worth, partially because of different settings having default values of different types and partially because we don't have any convenient way to get a list of all C++ settings.
JosJuice
force-pushed
the
android-new-config
branch
from
5d07c39 to
f97fa06
Compare
There was a problem hiding this comment.
- In-game graphics settings changes (tested Aspect Ratio and Post-processing) aren't immediately updated.
- In-game settings with custom game setting set are still modifiable but the change is ignored. Perhaps either make these non-modifiable and show a toast explaining why or make modifications save to the custom game settings?
- On Windows, "Insert SD Card" and the CPU Clock Override settings are modifiable in-game.
Weird, I'm pretty sure it worked before, but it doesn't seem to be working anymore... I'll take a closer look.
I tried to match the DolphinQt behavior where changes to such settings persist until you end the emulation session, since I had no particular reason to want to go against the DolphinQt behavior.
The reason they aren't modifiable in-game on Android is because they aren't using the new config system yet. |
To clarify with an example, if the OSD display setting is overridden to false, modifying that setting in-game will not allow OSD messages to be displayed. If that's intended behavior I'd like a toast when a user tries to modify an overridden setting in-game explaining that those changes will do nothing and not be retained.
That's fine, just making sure this was intentional. |
The intended behavior in that case is that OSD messages will be displayed for the rest of the current emulation session. If that's not happening, it sounds like a similar issue to the first of your three issues. |
Actually I can't reproduce that anymore. I'll assume I accidentally didn't clear my custom settings while testing unless I can reproduce it again. I think the "In-game graphics settings changes (tested Aspect Ratio and Post-processing) aren't immediately updated" is the only relevant issue now. |
The main activity loads settings essentially as soon as it starts, in order to determine which tab to show. If the process of stopping emulation has not finished at this point, a race condition may be triggered where two IOS kernels are created at once due to the emulation thread loading or saving the SYSCONF while the GUI thread is loading the SYSCONF. To fix this, we can wait for emulation to fully end before returning. Because this race condition is hard to reproduce, I have not been able to test that this actually fixes the race condition, or even that the cause of the race condition is exactly what I believe it is. But I am relatively confident.
JosJuice
force-pushed
the
android-new-config
branch
from
f97fa06 to
744c0b1
Compare
|
The issue with the graphics settings is fixed now. Turns out that I have to call |
This gives users the ability to edit settings while emulation is running, and improves the game settings editor by highlighting settings which are overridden and by showing the user's config instead of defaults for settings which are not overridden. This also makes it relatively easy for a future PR to add SYSCONF settings to the Android GUI.