Android: Add Insert SD Card and update the description #8708
Conversation
There was a problem hiding this comment.
I think you could get this PR reviewed more easily if you split it up into several PRs, since it combines Android things and non-Android things. The four bullet points you have in the PR description sounds like a clean way to separate this into 4 PRs (or maybe 3 PRs, if you think it's better to include the last change with one of the other changes).
Ebola16
changed the title
|
@JosJuice Done. I also swapped the order of the sentences in the new Insert SD Card description to put the more important sentence first. Thanks! |
|
After looking at the code, it seems like the USB keyboard option only works on Windows, so I don't think there's much point in exposing the setting on Android. |
Ebola16
changed the title
|
@JosJuice Done. That makes this PR simple. |
|
@JosJuice Can this get merged? |
|
Can this get merged? |
|
Instead of me posting occasionally to get non-controversial / reviewed PRs merged, can I be allowed to merge PRs myself? I just don't want to spam @JosJuice unnecessarily for features. I won't auto-merge PRs but I'd merge PRs like this one. Issue tracker dev access would also be helpful. |
|
Things have been a bit slow with reviews due to the current circumstances. This has an approval already so I'll merge it once I've gone through everything. I'm not a good coder so all I can do is test things, though this one does have a code approval making things easier. |
|
@JMC47 I understand that and thanks for merging this. That's why I suggested allowing me to merge PRs, It will make me sound less nagging and allow me to merge prerequisite PRs for future work. |
|
@Ebola16 I've given you dev access on the issue tracker. Let me know if it doesn't work. The requirements for getting merge rights in this repo are stricter (and I don't have the ability to give people merge rights anyway). |
|
@JosJuice Thank you! No worries about merge rights, I was just trying to find the right balance between spamming notifications and getting things merged. |
Implements https://bugs.dolphin-emu.org/issues/10700
Follow-up to #7920.
The path is modifiable by the user so we shouldn't mention it in the description.