Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arabic characters #39

Closed
Philmod opened this issue Apr 29, 2015 · 3 comments
Closed

Arabic characters #39

Philmod opened this issue Apr 29, 2015 · 3 comments

Comments

@Philmod
Copy link

Philmod commented Apr 29, 2015

Hey guys,

It doesn't work for some language:

> var t = "تحية الاسلام مدخل لدعوة غير المسلمين من الوافدين";
> slug(t);
''

Thanks,
Philmod
@dodo
Copy link
Owner

dodo commented Apr 29, 2015

Would you mind creating a pull request, where those chars get replaced by ASCII characters?
Keep in mind that node-slug is not capable of transliteration which is discussed in #8.

@Philmod
Copy link
Author

Philmod commented Apr 29, 2015

Yeah, I ended using that library.

@Philmod Philmod closed this as completed Apr 29, 2015
@montaro
Copy link

montaro commented Feb 10, 2016

I believe the Arabic letters are URL friendly, you just need not to omit them
#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dodo @montaro @Philmod