Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid having a drawn and typed signature at the same time #1516

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix: avoid having a drawn and typed signature at the same time #1516

merged 1 commit into from
Dec 27, 2024

Conversation

ephraimduncan
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
prd-app 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:34am
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:34am
stg-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:34am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
prd-docs ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 9:34am
prd-marketing ⬜️ Ignored (Inspect) Dec 27, 2024 9:34am
prd-openpage-api ⬜️ Ignored (Inspect) Dec 27, 2024 9:34am
stg-marketing ⬜️ Ignored (Inspect) Dec 27, 2024 9:34am

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ephraimduncan ephraimduncan requested review from Mythie and catalinpit and removed request for Mythie December 6, 2024 04:51
catalinpit
catalinpit reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@catalinpit catalinpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this happen? I couldn't reproduce it on the profile page or document signing page view.

sigsig.mp4

@doug-andrade
Copy link
Contributor

Where does this happen? I couldn't reproduce it on the profile page or document signing page view.

sigsig.mp4

If you have a Signature saved, but then you choose to type for a specific document. Next time you go sign a document it will default back to your saved signature from your profile, not the typed one.

@doug-andrade
Copy link
Contributor

https://www.loom.com/share/6e5f08edd90d4758864e91fbb165d84b?sid=3d0f3a6b-48ec-4459-9b5a-6d65c963ddb0

@catalinpit
Copy link
Contributor

Where does this happen? I couldn't reproduce it on the profile page or document signing page view.
sigsig.mp4

If you have a Signature saved, but then you choose to type for a specific document. Next time you go sign a document it will default back to your saved signature from your profile, not the typed one.

This makes sense. That's how the default saved signature should work. You can change the default signature on the profile page.

Also, the PR aims to solve something else - to avoid combining a drawn and typed signature.

@ephraimduncan
Copy link
Contributor Author

Also, the PR aims to solve something else - to avoid combining a drawn and typed signature.

Exactly, this is a reproduction. There are instances it doesn't happen but more often than not, it happens

reproduction.mp4

@dguyen dguyen force-pushed the fix/drawn-and-typed-signature branch from 4a4d03a to 5b611db Compare December 27, 2024 09:11
@vercel vercel bot temporarily deployed to Preview – prd-openpage-api December 27, 2024 09:11 Inactive
@dguyen dguyen merged commit ee6efc4 into main Dec 27, 2024
16 of 17 checks passed
@dguyen dguyen deleted the fix/drawn-and-typed-signature branch December 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguyen dguyen dguyen approved these changes

@Mythie Mythie Awaiting requested review from Mythie

@catalinpit catalinpit Awaiting requested review from catalinpit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ephraimduncan @doug-andrade @catalinpit @dguyen